Comments (6)
I feel even that would be a very redundant thing to do. Say, there are 3 transformations and 5 estimators, imagine having 15 combinations defined in the class that you are referring to. And, this is just the tip of the iceberg.
Rather, defining the default parameters, and overriding them with user arguments is a more decent way to go ahead.
from einstein.
No we just need to define them in pipeline, not build the pipeline with them. In that case we won't need to make permutations and combinations at all. We just need to list them for better reusuability.
from einstein.
But that can't be done in abstract class.
from einstein.
I am still trying to wrap my head around this.
This shouldn't be affecting your Model
class in any way.
We have used @abstractmethod
to only ensure that all the child classes MUST have those methods defined.
Like, flow
or pipeline
will definetely be needed when we are sub-classing this model in the final script that will bind all of this together.
The contents of it can be meddled with there, based on the user's choice.
Which is why, it's better to just create functions here with default values, which will be overridden by users, if need be.
I am not sure as to why defining the Model
class as abstract, or not would make a difference, to begin with.
The current design, I think helps leave all the choices at the meta-level. What do you say, @Anirudh-Kakarlapudi ?
from einstein.
Yeah cool, let's continue with the current plan. I was under the idea that we can't have code inside abstract methods, as in Java. But I need to check again if that's true in python, as we have been doing that already. If that is the case it does not make any difference.
from einstein.
So, how it works here is:
You define an abstract class, with methods (abstract) simply by doing a pass
under them.
It being an abstract class or not wouldn't affect method overriding in any way - it just makes it compulsary for the child classes to implement those methods.
from einstein.
Related Issues (15)
- Created a Base Class which can be used in all regression models. HOT 1
- need a parameter model to return a dictionary also HOT 2
- Dataset for models HOT 1
- Metrics to track model performance HOT 3
- Continuous integration HOT 13
- Class/Variable names HOT 1
- GCP Initialization Action HOT 6
- Whether `Model` class in base.py should remain abstract or not HOT 4
- Lock on 'develop' branch HOT 6
- Encryption of the csv file for data security HOT 3
- Error while testing HOT 9
- Unit tests for models HOT 2
- Adding a cross validation step HOT 2
- PVLib ForecastModel class HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from einstein.