Compilation warnings in re2 with `-Wpedantic` about duckdb HOT 10 CLOSED

Looks super-green now: https://github.com/duckdb/duckdb-r/actions/runs/9162129815/job/25188491799 .

Filed the clang-asan problem: #12142 .

The atlas check is not a problem.

I don't understand why valgrind still finds problems. Investigating.

from duckdb.

@szarnyasg: Thanks for looking into it.

In gcc14, there are even more warnings:

    /usr/local/gcc14/include/c++/14.0.1/bits/move.h:221:11: warning: '((__vector(2) long unsigned int*)this)[1]' is used uninitialized [-Wuninitialized]
    /usr/local/gcc14/include/c++/14.0.1/bits/move.h:221:11: warning: '*(__vector(2) long unsigned int*)this' is used uninitialized [-Wuninitialized]
    /usr/local/gcc14/include/c++/14.0.1/bits/move.h:221:11: warning: '((void (**)(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >))this)[2]' is used uninitialized [-Wuninitialized]
    /usr/local/gcc14/include/c++/14.0.1/bits/move.h:221:11: warning: '((duckdb::FileBuffer**)this)[2]' is used uninitialized [-Wuninitialized]

Check results: https://cran.r-project.org/web/checks/check_results_duckdb.html

from duckdb.

The first two issues are easily fixable, but found this comment:

// Work around the bug affecting flexible array members in GCC 6.x (for x >= 1).
// (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70932)
#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ == 6 && __GNUC_MINOR__ >= 1
    std::atomic<State*> next_[0];   // Outgoing arrows from State,
#else
    std::atomic<State*> next_[];    // Outgoing arrows from State,
#endif

So this seems intentional to work around a GCC bug?

from duckdb.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70932

from duckdb.

PR for first part is here: #11956

from duckdb.

The re2 package on CRAN has this fixed, will copy their fix over.

from duckdb.

second PR is here: #11978

from duckdb.

@krlmlr do we have a CI run already that would have found those?

from duckdb.

Yes. Easiest when that PR is merged and vendored here.

from duckdb.

Fixed in upstream

from duckdb.