DB connection fails to close about fakeindexeddb HOT 6 CLOSED

Actually, this doesn't seem to be a bug at all. According to MDN, onclose only fires on unexpected closes.

It sounds like your original use case is for upgrading a db when other connections are open. I believe what you want is onversionchange, which fires "when a database structure change [...] was requested elsewhere"

from fakeindexeddb.

Do you have code? I tried to reproduce and found that, though the close event handler isn't firing, db closing seems to work OK:

require('fake-indexeddb/auto');

indexedDB.deleteDatabase('mydb').onsuccess = event => {
  const openreq = indexedDB.open('mydb', 1);

  let db_connection;
  openreq.onupgradeneeded = event => {
    db_connection = event.target.result;
    db_connection.onclose = () => console.log('closed');
  };

  openreq.onsuccess = event => {
    db_connection.close();
    const reopenreq = indexedDB.open('mydb', 2);
    reopenreq.onupgradeneeded = () => console.log('modifying db');
    reopenreq.onsuccess = () => console.log('db re-opened');
  }
};

// 'closed' does not get logged, but 'modifying db' and then 'db re-opened' do

of course, the close handler should be firing, so that's still a bug. Also fails with addEventListener('close', ...).

from fakeindexeddb.

@Quelklef Thanks for your help, I've resolved my problem. The confusion came from the failure of the onclose event to fire. That's the only bug here. I'm closing this issue. You can create another one for the event bug.

from fakeindexeddb.

Great, will do!

from fakeindexeddb.

Thanks @Quelklef the reason my upgrade requests were blocked was because some of the open db instances didn't have the onversionchange handler. I initially thought the DB connections weren't closing since the onclose didn't fire but once I noticed the aforementioned discrepancy I was able to resolve the issue. That's why I said "I have resolved my problem"

from fakeindexeddb.

got it 👍 👌

from fakeindexeddb.