Giter VIP home page Giter VIP logo

Comments (5)

dunbar12138 avatar dunbar12138 commented on May 26, 2024

Hi! Thanks for your interest!

If you are using NDC space, you need to figure out the linear transformation to NDC space, which is about the near/far plane, and apply the transformation to the depths.

from dsnerf.

mertkiray avatar mertkiray commented on May 26, 2024

Can you please open up your answer a little bit more?

I project the depth values into the image space to get the depth values and coordinates for this depth value for get_rays_by_coord_np.

My bds.min() and bds.max() is 3.5933347725766653 56.21810500817462

What do you mean by figuring out the linear transformation?

Also, we should convert the poses into [r, u, -t] and my
perspective cameras are in x = right, y = down, z = forward coordinate system
my world coordinate system is : x = forward, y = left, z = up.

I converted them into [r,u, -t] by saying
poses = np.concatenate([poses[:, 0:1, :], -poses[:, 1:2, :], -poses[:, 2:3, :], poses[:, 3:, :]], 1)

Does my calculations make sense?

Thank you so much :)

from dsnerf.

mertkiray avatar mertkiray commented on May 26, 2024

Hey again,

Can you please explain how can I convert the depth map in NDC into real depths to compare for the loss? I could not manage to do it.

from dsnerf.

NagabhushanSN95 avatar NagabhushanSN95 commented on May 26, 2024

I think by "figure out the linear transformation to NDC space, which is about the near/far plane, and apply the transformation to the depths", the author probably means you should convert depth as

ndc_depth = (depth - near) / (far - near)

from dsnerf.

NagabhushanSN95 avatar NagabhushanSN95 commented on May 26, 2024

I was wrong above. The conversion to NDC space is not so simple. Please go through the NDC derivation given by Mildenhall here. The transformation I found was

ndc_depth = 1 - (oz + tn * dz) / (oz + depth * dz)

Again, this is what I think should be the correct mapping, though I'm not 100% sure.

from dsnerf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.