Unit tests failing about go-coap HOT 3 CLOSED

Do you get same string array each time in this test case?

[vtrushkin@TARDIS go-coap]$ git pull origin master
From https://github.com/dustin/go-coap
 * branch            master     -> FETCH_HEAD
Current branch master is up to date.
[vtrushkin@TARDIS go-coap]$ git hist -1
* 10a6085 2015-07-27 | Implement extended option headers (HEAD -> master, origin/master, origin/HEAD) [Vyacheslav Trushkin]
[vtrushkin@TARDIS go-coap]$ go test
PASS
ok      github.com/dustin/go-coap   0.002s

from go-coap.

I think found the problem. In message.go:469 we should have:

    sort.Stable(&m.opts)

to ensure that the sort doesn't change the order of options with the same option ID (for example, the parts of the URLPath option).

Also while we're around this, it might be simple to have this implementation for SetPath:

func (m *Message) SetPath(s []string) {
    m.SetOption(URIPath, s)
}

(because SetOption already knows how to deal with slices.)

from go-coap.

Oh cool, thanks.

SetOption for SetPath seems to do the trick without introducing any test
failures as well

On Tue, Sep 22, 2015 at 10:48 AM Dov Murik [email protected] wrote:

I think found the problem. In message.go:469 we should have:

sort.Stable(&m.opts)

to ensure that the sort doesn't change the order of options with the same
option ID (for example, the parts of the URLPath option).

Also while we're around this, it might be simple to have this
implementation for SetPath:

func (m *Message) SetPath(s []string) {
m.SetOption(URIPath, s)
}

(because SetOption already knows how to deal with slices.)

—
Reply to this email directly or view it on GitHub
#24 (comment).

from go-coap.