Updating KIAUH Script fails about kiauh HOT 11 CLOSED

Fixed it by myself with deletion of the old install_klipperscreen.sh, but this wasn't edited by myself before o_O

from kiauh.

The error message states, that you have made changes to the file install_klipperscreen.sh.
If you modify a script yourself, it can't be updated anymore that easily.

from kiauh.

I am facing the same Issue. I haven't made any changes accordingly. My Solution was a bit rough but it worked.
git reset --hard
Cheers

from kiauh.

Okay that is weird.
The file got updated 2 days ago, but that shouldn't create any issue. I have no idea why git then complains about some (rather) non-existent local changes. I try and investigate this issue.

from kiauh.

@nicedevil007 so you updated your kiauh from 43a724b . that was a point in history where the install_klipperscreen.sh fix wasn't applied yet. Are you sure you haven't modified the file yourself before.
In #59 you said, you updated kiauh after that patch from jordan was provided and i merged it. But that would mean, your kiauh would be already PAST commit 43a724b.

@KwadFan From which commit did you make the update? The same as nicedevil?

i just updated my own kiauh on my production pi...

went through without an issue. and i had that klipperscreen fix already applied as well as you can see because the update startet from 8bf20aa

from kiauh.

It was commit f128950

from kiauh.

@KwadFan okay so you haven't updated for a longer time then. That makes troubleshooting a bit more complicated.

Especially now that i got a screenshot from someone who updated successfully exactly after 43a724b

and someone who updates successfully after a44ae4c

At the moment i don't have an idea where to look for the issue? It seems very random to me

from kiauh.

@nicedevil007 so you updated your kiauh from 43a724b . that was a point in history where the install_klipperscreen.sh fix wasn't applied yet. Are you sure you haven't modified the file yourself before.
In #59 you said, you updated kiauh after that patch from jordan was provided and i merged it. But that would mean, your kiauh would be already PAST commit 43a724b.

@KwadFan From which commit did you make the update? The same as nicedevil?

i just updated my own kiauh on my production pi...

went through without an issue. and i had that klipperscreen fix already applied as well as you can see because the update startet from 8bf20aa

I'm pretty sure that I didn't do that even by accident... can't remember that I ever went into the scripts folder in the kiauh directory...

for me it doesn't matter anymore, because fixed it with the deletion of the klipperscreen install script inside the scripts folder. maybe it is a rare behaviour I got... or even anything else is wrong on my installation (remember that I can't install klipperscreen with the pi user before)

now with the updated KIAUH script it seems that KIAUH recognizes the installation of klipperscreen even if it was installed with root user. I was able to update it through your script! so maybe everything is fixed now? <3

from kiauh.

@th33xitus
Yes, not running latest and greatest brings sometimes major issue to the table.
Updates haven get the Attention they should have on my printer :)

In my opinion, I would brute force the update like
git reset --hard
because in my mind KIAUH shouldnt be modified, unless you know what are you doing.
And at this point you should know to prevent such Errors or even to deal with them.
Its more curious for lazy people or peoples without the technical background in mind of Linux Administration and Shell scripting.
So these last named should live with the circumstance that you made the Update rules. Period.
So, if you ask me, brute force the Update to prevent such randomly happening Issues.
I think this issue could be closed for now.
Regards.

from kiauh.

So, if you ask me, brute force the Update to prevent such randomly happening Issues.

You idea is good. I think i will implement such brute force reset. I agree with you in every point you mention.

from kiauh.

30ca396 should solve this issue from now on.
Although i still would like to know why that occurred suddenly...

from kiauh.