Giter VIP home page Giter VIP logo

Comments (2)

xolotl avatar xolotl commented on June 29, 2024

URLs to the document and individual annotations provided in the Hypothesis sidebar lead to the statically hosted PDFs rather than the full DocDrop experience. For example, for this doc: https://docdrop.org/pdf/Student-Speak-2020-FINAL-aaXkf.pdf/ the URL offered in the sidebar to the page is: https://hyp.is/go?url=https%3A%2F%2Fdocdrop.org%2Fstatic%2Fdrop-pdf%2FStudent-Speak-2020-FINAL-aaXkf.pdf&group=__world__ and the URL offered for a specific annotation is like https://hyp.is/3ORkEB6-EeudCeP_WofpaA/docdrop.org/static/drop-pdf/Student-Speak-2020-FINAL-aaXkf.pdf

This means none of the usual Hypothesis sharing pathways work well in DocDrop.

image

from droppdf.

genuineBuildMonkey avatar genuineBuildMonkey commented on June 29, 2024

I've looked into this and tried to come up with a workaround. Still thinking about it.

I believe Hypothesis obtains the link (used for sharing) from the canonical url created by PDFJS. This is the link to the actual document (which is provided to PDFJS on creation). I don't see an explicit way to override that and resetting it after the fact unsurprisingly doesn't change the link picked up by Hypothesis.

This issue brings up another important point. With the new cloud storage scheme we must change the underlying document url provided to PDFJS from the S3 (cloud storage) one to an actual docdrop link as the cloud storage links remain valid for a limited time.

I'm not sure we will be able to force Hypothesis to recognize the share link as DocDrop links (unless we can find a workaround) but we do need to change the document source url.

from droppdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.