Giter VIP home page Giter VIP logo

Comments (7)

nelsonic avatar nelsonic commented on May 27, 2024 1

@Shivang44 yes, it appears to be working as expected.
hapi-socketio-redis-chat-example-working

No console errors. ✅

Thanks again! 👍

from hapi-socketio-redis-chat-example.

Shivang44 avatar Shivang44 commented on May 27, 2024

Well... this might be my fault. It turns out the new socket.io js client file we included doesn't "work". Not sure why that is.

If we include the original file,

https://cdn.socket.io/socket.io-1.3.5.js

It works. The issue we were having was that link was broken, but today, it seems the link has fixed itself. So if we didn't change anything and just waited a day it would have fixed itself haha. Anyways, I'm sorry about this, I can either create a new branch with the original link or we could revert to the commit before the merge?

I pulled in the code as-is and then just changed the socket.io client JS file to the one above on my digitalocean box, and it seems to work: http://107.170.109.97:8000/

Thanks and sorry again for the troubles.

from hapi-socketio-redis-chat-example.

nelsonic avatar nelsonic commented on May 27, 2024

@Shivang44 cool. let's go back to the previous version. do you have time to PR? 👍

from hapi-socketio-redis-chat-example.

Shivang44 avatar Shivang44 commented on May 27, 2024

@nelsonic Done. It might have had to do with the version differences (1.3.5 vs 1.4.6).

from hapi-socketio-redis-chat-example.

nelsonic avatar nelsonic commented on May 27, 2024

@Shivang44 thanks for helping to debug this.
the older version of Socket.io has been deployed to the app: view-source:https://hapi-chat.herokuapp.com/ but the issue is still there. sad times. 😞

from hapi-socketio-redis-chat-example.

Shivang44 avatar Shivang44 commented on May 27, 2024

@nelsonic That's really strange. I stopped my server, pulled in the latest repo, and just ran it as-is. Works for me. I'll take a deeper look at later today, but I think you and your team know much more about nodejs and websockets than me. :)

Nevertheless, I'll make a new PR if I do figure it out. Thanks for spending time merging the PR's!

from hapi-socketio-redis-chat-example.

Shivang44 avatar Shivang44 commented on May 27, 2024

@nelsonic Is this resolved? It seems to work on the link you posted.

from hapi-socketio-redis-chat-example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.