Switch step 4 and step 5? about phoenix-liveview-counter-tutorial HOT 6 CLOSED

But then perhaps we can simply remove the first two lines of Step 4

Some editors (in my case VScode) display an error if we don't import Phoenix.LiveView.Router on step 4. The error will be gone as soon as step 5 is finished but I'm wondering if it will confuse people.
we could add a warning on step 4 or we could merge step 4 and 5 together?

from phoenix-liveview-counter-tutorial.

Ah .... ok.
If your editor is complaining, which is impressive that it understands the lack of the import,
then let's make the switch!

from phoenix-liveview-counter-tutorial.

Change included in PR #6 👍

from phoenix-liveview-counter-tutorial.

resolved with PR #6

from phoenix-liveview-counter-tutorial.

@SimonLab good observation. 👍
But then perhaps we can simply remove the first two lines of Step 4
given that the Phoenix.LiveView.Router is already imported in endpoint.ex.

from phoenix-liveview-counter-tutorial.

Included in #6

from phoenix-liveview-counter-tutorial.