Doesn't compile on Illumos about process_control HOT 7 CLOSED

Thank you for this issue! The primary reason for the compilation errors is missing definitions from libc: rust-lang/libc#2696

If that pull request is merged once issues are fixed, I will update the implementation here and release a new version with support for this platform.

from process_control.

Thanks!

from process_control.

I tested with my pending rust-lang/libc#2697 patch, and the build was content, except for the id_t type issue noted at L239. Although most platforms use u32 for id_t, illumos and a few others use something different. I suspect some TryInto handling would address that in a platform neutral manner.

from process_control.

@pfmooney Thank you, and thank you for testing the fix!

You're right that the implementation here does need to be adjusted. Unfortunately, the return type of Child::id makes it unclear whether TryInto or as is always the right answer. I'll be looking into the standard library implementations a bit more to see which would be the best option.

from process_control.

The implementation has been updated for this crate and compiles successfully with the changes in libc. Once a libc version is released with rust-lang/libc#2697, I will verify the fix and release a new version with an updated libc requirement.

from process_control.

Version 3.3.0 has been published with Illumos support. Thanks for reporting the issue!

from process_control.

Thanks!

from process_control.