Dismissing during page load causes KVO crash about dznwebviewcontroller HOT 10 OPEN

When comparing my changes against HEAD, some of them were already done. Since I wasn't able to push to the repository, and unable to create a pull request, I'll just post a screenshot of my changes below.

from dznwebviewcontroller.

Have you found solution?
Actually i have got this crash once and i am not able to reproduce this. Are you able to reproduce this now?

from dznwebviewcontroller.

Sorry, haven't taken time to investigate.

On Mon, Jun 6, 2016 at 3:03 AM Sahana Kini [email protected] wrote:

Have you found solution?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAbHOXx-KFfUKGTtKigvdePqbUhBXfaJks5qI8YkgaJpZM4IqAlR
.

from dznwebviewcontroller.

Maybe one quick solution is to disable interactivity while the view is presented?

from dznwebviewcontroller.

We have seen this crash as well. I've changed the navigationBar property of DZNWebViewController to strong and also migrated all references to self in the dealloc function to iVars. If crashlytics from the next release shows no further such crashes, I may commit the change to github.

from dznwebviewcontroller.

Hi. Any updates?

from dznwebviewcontroller.

We will release next week, and I'd give it another week to see no crashes in production. So, in another 2 weeks I may commit. The changes mentioned above won't hurt anything, so you may as well give them a try if it is urgent. I just didn't want to commit until I knew for sure.

from dznwebviewcontroller.

Crashlytics was showing at least one crash a day. Now after a week it hasn't shown any. I'm ready to contribute the fix to DZNWebViewController, but I'll need help as this is my first time. I tried to push a new branch with the changes but I don't think I have permission. (Once I can push the branch, I was planning to make a pull request) Could somebody give me permissions to contribute? Thanks!

from dznwebviewcontroller.

Any updates?

from dznwebviewcontroller.

I'm still experiencing this problem with latest 3.2. Most notably, it looks like the suggestion to change UINavigationBar from weak to strong was never made.
Getting a few of these crashes a day right now. Will there be a new release with these changes?

from dznwebviewcontroller.