Giter VIP home page Giter VIP logo

Comments (11)

JordanMarr avatar JordanMarr commented on May 18, 2024 2

Incoming PR...

from dapper.fsharp.

JordanMarr avatar JordanMarr commented on May 18, 2024

It looks like you are joining on an Option property.
Try this:
on (Some ez.KstStelle = erz.USER_KstUebergeordnet)

from dapper.fsharp.

tforkmann avatar tforkmann commented on May 18, 2024

I now get following error message:

Could not get data "The method or operation is not implemented.

from dapper.fsharp.

tforkmann avatar tforkmann commented on May 18, 2024

I guess that error message comes from here:

let notImpl() = raise (NotImplementedException())

from dapper.fsharp.

JordanMarr avatar JordanMarr commented on May 18, 2024

Ah ok, you found a bug then.
the bug is that Option types are only unwrapped in the where statement expressions.
It should be a pretty easy fix though.

from dapper.fsharp.

Dzoukr avatar Dzoukr commented on May 18, 2024

Fixed in v2.0.1 thanks to @JordanMarr πŸ‘

from dapper.fsharp.

tforkmann avatar tforkmann commented on May 18, 2024

Ahh thanks. Just wanted to sent a PR in as well^^ But yours is even better

from dapper.fsharp.

tforkmann avatar tforkmann commented on May 18, 2024

Awesome works! Thanks for the help!

from dapper.fsharp.

JordanMarr avatar JordanMarr commented on May 18, 2024

Ahh thanks. Just wanted to sent a PR in as well^^ But yours is even better

Well it just occurred to me that group by probably has the same problem, so feel free to a unit test for groupBy and groupByMany that takes an Option type.

from dapper.fsharp.

JordanMarr avatar JordanMarr commented on May 18, 2024

Actually there is no groupByMany, just groupBy which can take a tuple, and it does indeed need the same fix if you’re up for it. (Let me know).

Also the xml doc comment for groupBy is wrong on the select builder.

from dapper.fsharp.

JordanMarr avatar JordanMarr commented on May 18, 2024

FYI, I just checked and groupBy worked fine with option types (I added a new unit test to make sure). So no other fix is needed.

from dapper.fsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.