PR only build? about hub-ops HOT 7 CLOSED

I am not sure I understand this request. That action only runs on pull requests. The build-deploy action runs after merge. (This image does not get re-built if it exists already).

from hub-ops.

oh - well i saw that all of nathan's pr's were failing and you mentioned that was because they don't have access to secrets. in my mind, i thought maybe pull requests didn't need to push to dockerhub and thus wouldn't need authentication. somehow on travis when you submitted a PR it would build but not push. Maybe however that was because travis stored the secrets instead of github?

essentially it would be nice to merge passing PR's is the end goal and know the containers build ok before doing so. short term we can totally deal as things seem to be working beautifully now!! thank you!

from hub-ops.

Ah, I get it now. Because the tests involve authentication and reading secrets stored in Settings -> Secrets, PR builds will only pass if they originate from branches of this repo (not from forks). So, we should make sure that contributors have the permission to push branches and create pull requests, and we should update the docs to reflect this.

from hub-ops.

In the previous travis-based CI, the deploy.py script used files in the secrets dir to authenticate to dockerhub and gcloud. In the move to Actions, we've followed the GitHub guides for moving secrets to repository settings. Also, the deploy script can now be run locally without fear of messing up local authentication to services.

from hub-ops.

It looks like it might be possible to run the existing Action on PRs from forks, based on this blog post by changing the event type to pull_request_target.

from hub-ops.

oh - that's worth ha shot @kcranston we do get outside contributors every once in a while.

from hub-ops.

this was fixed. closing

from hub-ops.