Improve logs (introduce a progress-bar for tty devices) about earthly HOT 9 CLOSED

Yes that is from pulling the image. My internet connection is slow so I get a higher amount of those lines.
With a tty, a simple wget-like progress bar would be better.
Without a tty, one solution is to filter out duplicate lines (that at least reduces it down to 100 lines for each pull).

from earthly.

It's a good start, however you probably need a separate progress bar for each of the items in ss.Statuses. These are multiple activities taking place in parallel and the relevant progress bars need to be updated in parallel. Feel free to open a PR even if it's WIP.

from earthly.

Makes sense, Brandon. We need to improve this.

(I believe those specific lines are from the progress of pulling some docker image - this can be made less verbose.)

from earthly.

#143 changes the behaviour to only print out the progress every 5 seconds.

I agree that a tty progress bar would be nice to implement one day, so maybe we should leave this issue open?

from earthly.

Hey @vladaionescu! Can I work on this issue?

from earthly.

Sounds good @Gituser143. This is where progress is printed BTW: https://github.com/earthly/earthly/blob/master/builder/solver_monitor.go#L178. Keep in mind that there may be multiple progress bars ongoing at a time and that the printing itself is being worked on in parallel: #338.

CC @MadhavJivrajani

from earthly.

Thank you @vladaionescu! I'll get to it...

from earthly.

@vladaionescu I've implemented a simple progress bar. It's declared here and values are updated like this. Let me know if I can open a PR so that you can see the changes and tell me what changes I'll have to make.

My overall implementation looks kind of like this:

var on sync.Once
progressBar := pb.New(100)
for _, vs := range ss.Statuses {
  .
  .
  .  
  progress := int(0)
  if vs.Total != 0 {
    progress = int(100.0 * float32(vs.Current) / float32(vs.Total))
  }
  if vs.Completed != nil {
    progress = 100
  }
  if vm.shouldPrintProgress(progress) {
    .
    .
    .
    on.Do(func() {
      vm.console.Printf("%s\n", vs.ID)
      progressBar.Start()
    })
    progressBar.SetCurrent(int64(progress))
  }
}
progressBar.Finish()

from earthly.

This has been implemented and will be in the next release.

from earthly.