Comments (12)
Good that I have copied the clean branch after CRAN submission of parameters (https://github.com/easystats/parameters/tree/release_0_19_0_branch) - the main-branch now includes several breaking changes that are not properly tested and might break other packages, so it's possible to include the patch into the release_0_19_0_branch
and submit a fix to CRAN, if necessary. :-)
from correlation.
Warning in genhypergeo_series_pos
I started having this warning fairly often too for bayesian correlations (but no errors in correlation), did something change in BayesFactor to cause that?
from correlation.
I doubt it, since BayesFactor was last updated in July, and we would have noticed such a change way earlier instead of now.
I have a hunch that this has to do with a change in either parameters or bayestestR.
from correlation.
Here's a reprex:
library(parameters)
library(dplyr, warn.conflicts = FALSE)
df <- as.data.frame(ggplot2::msleep)
x <- filter(df, vore == "carni")
rez <- BayesFactor::correlationBF(x$sleep_total, x$awake, rscale = "medium")
#> Warning in genhypergeo_series_pos(U = c((n - 1)/2, (n - 1)/2), L = ((n + :
#> Series not converged.
rez
#> Bayes factor analysis
#> --------------
#> [1] Alt., r=0.333 : NA ±0%
#>
#> Against denominator:
#> Null, rho = 0
#> ---
#> Bayes factor type: BFcorrelation, Jeffreys-beta*
params <- parameters::model_parameters(rez)
params
#> Bayesian correlation analysis
#>
#> Parameter | Median | 95% CI | pd | Prior
#> ----------------------------------------------------------
#> rho | -1.00 | [-1.00, -1.00] | 100% | Beta (3 +- 3)
#>
#> Uncertainty intervals (equal-tailed) and p-values (two-tailed) computed
#> using a MCMC distribution approximation.
Created on 2022-10-07 with reprex v2.0.2
from correlation.
could it be with the removal of ROPE?
from correlation.
parameters uses datawizard::remove_empty()
, which removes columns with completely NA
(which is a new behaviour, I think), so the BF is missing for this particular combination of variables, which causes the error in correlation.
A fix would be to check here:
correlation/R/cor_test_bayes.R
Line 83 in e31942e
if the BF column exists, and if not, add BF <- NA
. We must ensure the columns have the right order (so we might need to sort), so params
can be rbind()
to the final results (see cor_test()
).
from correlation.
We should add @IndrajeetPatil example as test, once the issue is resolved.
from correlation.
shouldnt we add that in parameters? The output should include the BF col even if NA
from correlation.
Yes, I agree. But maybe for now it's better to have this fix in correlation, too? I just submitted parameters two days ago. 😬
from correlation.
haha okay makes sense then
from correlation.
There must have been a reason why we changed the behaviour in model_parameters.BFBayesFactor()
. We added
# ==== remove rows and columns with complete `NA`s
out <- datawizard::remove_empty(out)
I think it's related to the new API of effectsize, which might return empty columns or rows that we didn't wanted to have? But we were not considering that the BF could be NA
.
from correlation.
I think it's related to the new API of effectsize, which might return empty columns or rows that we didn't wanted to have? But we were not considering that the BF could be NA.
Yes, the change in parameters is good. We just need to make a few exceptions, where necessary.
I have added tests and done some other preparations necessary for a new CRAN release of correlation.
Are there any other high prio issues that need to be resolved before this happens?
cc @bwiernik
from correlation.
Related Issues (20)
- Some tests are failing for R < 4.0
- CRAN check failures HOT 3
- Create GitHub release corresponding to CRAN release
- Changing aesthetics of the correlation plot HOT 2
- Costumizing priors HOT 1
- Multilevel correlation changes when more correlations are computed HOT 6
- Suggestion of new function: `cormatrix_to_excel()` HOT 4
- Factors don't always work as intended
- Multilevel rank correlation HOT 1
- refactoring the `correlation` package HOT 6
- Package version doesn't follow easystats' versioning conventions HOT 1
- Bayesian partial correlations
- bayestestR HOT 2
- X
- Update documentation to discuss handling of missing values HOT 1
- specify adjustment variable HOT 1
- Time series auto- and cross-correlations HOT 1
- A new correlation coefficient (Chatterjee) HOT 8
- Expanding Kendall's Tau to include Tau a and Stuart's c
- Update `{correlation}` on CRAN to prevents user from seeing deprecation warnings HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from correlation.