Giter VIP home page Giter VIP logo

Comments (5)

IndrajeetPatil avatar IndrajeetPatil commented on June 26, 2024

@easystats/maintainers Any ideas?

from easystats.

etiennebacher avatar etiennebacher commented on June 26, 2024

I can't reproduce the failure for tests in random order but I suspect that the definition of test failure and test error doesn't work when there's only 1 test and that this test is skipped (I don't know why, it's the only thing I can think of). Btw, what's the difference between failure and error for testthat?

Removing the reporter = "silent" argument would probably give more info on this

from easystats.

IndrajeetPatil avatar IndrajeetPatil commented on June 26, 2024

Btw, what's the difference between failure and error for testthat?

  • Failure: Actual value doesn't match with expected value
  • Error: Test code itself couldn't be run successfully

So the random test order workflow is now passing. It was failing because Pandoc wasn't installed for this workflow, and flaxdashboard seems to require it.

I still don't understand why code coverage workflow is stuck in infinity.

from easystats.

etiennebacher avatar etiennebacher commented on June 26, 2024

I think covr doesn't take into account the skip_ calls. Locally, I tried to put all kind of skip_ in the test file. devtools::test() correctly skips all of them, but covr::package_coverage() stil returns the same percentage as if there were no skips. So maybe it stays stuck forever in one of the interactive tests?

from easystats.

IndrajeetPatil avatar IndrajeetPatil commented on June 26, 2024

Thanks! That was indeed the issue. Skipping these tests during code coverage fixes that workflow. I will investigate which is the offending test and why it gets stuck.

from easystats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.