Giter VIP home page Giter VIP logo

Comments (4)

 avatar commented on August 17, 2024 1

I think if we use Azure Pipelines, we wouldn't need to use Travis so we could take that configuration out.

from benchmarkstt.

 avatar commented on August 17, 2024

I played about with Azure Pipelines and GitHub branch protection last night and concluded that while it's a little difficult to set up, it is beneficial.

We can set up multiple Azure Pipeline jobs to run tests on different operating systems and a separate job that runs pycodestyle. The tests successfully run on Windows and Mac VMs too, which are currently failing on Travis.

By separating the jobs we can configure GitHub to block merging if the tests fail, but perhaps we wouldn't want to block if linting fails - we would get that level of flexibility if we want.

I'm not saying we should use it - rather it's a possibility. Take a look at my fake PR on my fork of this repo. It's fairly difficult to see the output of pycodestyle, I hope it's possible to expose it better.

from benchmarkstt.

MikeSmithEU avatar MikeSmithEU commented on August 17, 2024

@danpope-bbc I'm all for this, for me this can be implemented as-is, and we can still tune the pycodestyle settings, block or not-block, etc. later.
Would you also keep the current travis configuration (doesn't hurt really, but indeed isn't cross-os), or completely replace it with the new checks?

from benchmarkstt.

MikeSmithEU avatar MikeSmithEU commented on August 17, 2024

PEP 8 has become the used standard, todo:

  • properly document this decision.

from benchmarkstt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.