Giter VIP home page Giter VIP logo

Comments (6)

josephzhang8 avatar josephzhang8 commented on June 17, 2024 1

Thx, Atieh!

from thalassa.

pmav99 avatar pmav99 commented on June 17, 2024

You will need to update the implementation too. As it is it will only work with rectangular regions. For a polygon you will need to use some shapely method like https://shapely.readthedocs.io/en/stable/reference/shapely.contains.html or geopandas sjoin: https://geopandas.org/en/stable/docs/reference/api/geopandas.sjoin.html.

And you will need to check performance for large meshes. The pure numpy implementation we have here is probably faster than the alternatives. Nevertheless, try to get something working and if performance proves to be problematic you can investigate making it faster afterwards (e.g. leverage numba or something).

from thalassa.

josephzhang8 avatar josephzhang8 commented on June 17, 2024

I cannot find Searvey anymroe; anyone? Thx.

from thalassa.

AtiehAlipour-NOAA avatar AtiehAlipour-NOAA commented on June 17, 2024

You will need to update the implementation too. As it is it will only work with rectangular regions. For a polygon you will need to use some shapely method like https://shapely.readthedocs.io/en/stable/reference/shapely.contains.html or geopandas sjoin: https://geopandas.org/en/stable/docs/reference/api/geopandas.sjoin.html.

And you will need to check performance for large meshes. The pure numpy implementation we have here is probably faster than the alternatives. Nevertheless, try to get something working and if performance proves to be problematic you can investigate making it faster afterwards (e.g. leverage numba or something).

Thanks for the quick response and the detailed explanation. For now, I am using a rectangle region but I wanted to confirm if there's a possibility to switch to a polygon later on. Thanks once again.

from thalassa.

AtiehAlipour-NOAA avatar AtiehAlipour-NOAA commented on June 17, 2024

I cannot find Searvey anymroe; anyone? Thx.

Hi, please check here: https://github.com/oceanmodeling/searvey

from thalassa.

pmav99 avatar pmav99 commented on June 17, 2024

https://github.com/asascience-open/xarray-subset-grid

from thalassa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.