Invalid editorconfig.excludes throw NullPointerException about editorconfig-maven-plugin HOT 4 CLOSED

I guess we need a null check here https://github.com/ec4j/editorconfig-maven-plugin/blob/master/editorconfig-maven-plugin/src/main/java/org/ec4j/maven/AbstractEditorconfigMojo.java#L313 and a test case. A PR is welcome :)

from editorconfig-maven-plugin.

I was thinking... What do you think of the "for" looks like this?

for (String exclude : excludes) {
    if (exclude == null || exclude.trim().length() == 0) {
        continue;
    }
    excls.add(exclude);
}

Maybe creating a StringUtils to check if a String is null or empty is a good one.

from editorconfig-maven-plugin.

Well, if you ask me, add() under if would be one line less.

for (String exclude : excludes) {
    if (exclude != null && exclude.trim().length() > 0) {
        excls.add(exclude);
    }
}

BTW, is the trim() necessary? AFAIK, Maven trims the values coming from pom.xml itself but I have no idea about list items passed on the command line.

Maybe creating a StringUtils to check if a String is null or empty is a good one.

I am not in favor of that. I find the expression better readable.

from editorconfig-maven-plugin.

Fixed in the just released version 0.0.11. Thanks again for the report.

from editorconfig-maven-plugin.