Giter VIP home page Giter VIP logo

Comments (3)

shahadat3669 avatar shahadat3669 commented on July 30, 2024 1

Hi @Eccb7 @Izebiafe @Anand8317 ,

Your project is complete! There is nothing else to say other than it's time to merge it :shipit:
Congratulations! 🎉

Highlights

✅ each card on the board has a descriptive title and the number of points
✅ tasks are distributed in a fair way
✅ The board has 4 columns as expected

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Contact me: Shahadat Hossain
GitHub LinkedIn Slack Email

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

from fast-recipes.

shahadat3669 avatar shahadat3669 commented on July 30, 2024

Hi @Eccb7 , @Anand8317 and @Izebiafe

Great job so far! 👏 You've done well, and you're almost there for the next project ⏭️, but there are a few issues 🐛 that you still need to work on.

Don't Worry 🙏

It's okay to have bugs in your code. 🆗 Please see this code review as an opportunity to learn practical coding skills and discover new tips that can improve your code quality 💯 and help you get even better 💼.

I will guide you on how to address these areas down below 👇.

Highlights

✅ each card on the board has a descriptive title and the number of points
✅ tasks are distributed in a fair way
✅ PR has information about the number of people in their group

Required Changes ♻️

Please take note of the following suggestions:

  • You have added the columns To Do, In Progress, and Done to the board. However, based on your previous project, it is recommended to have four columns for the board. It is suggested to add another column for In Review. The board should have the following columns: To Do, In Review, In Progress, and Done. 🙏

  • Currently, there are no details in the card about who will work with the controllers. It is recommended to either add a new card or include the details in the description if it is part of an existing card. 🙏

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Have any doubt ❓

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Contact me: Shahadat Hossain
GitHub LinkedIn Slack Email

⚠️ WARNING ⚠️

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

from fast-recipes.

Eccb7 avatar Eccb7 commented on July 30, 2024

Much appreciation @shahadat3669

from fast-recipes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.