Comments (7)
Thanks for the feedback.
What versions of Mongoose and Mongo DB are you using this with?
from mongoose-geojson-schema.
Mongoose is 3.8.8 and Mongo is 2.6
from mongoose-geojson-schema.
I put in a pull request that fixes it on my system.
from mongoose-geojson-schema.
I'm noting that this was the meat of the proposed update. I'm not crazy about it because while it solved the issue at hand, it weakened validation. I'd like to keep some stricter validation if possible while also addressing the issue.
diff --git a/GeoJSON.js b/GeoJSON.js
index 7423733..a054818 100644
--- a/GeoJSON.js
+++ b/GeoJSON.js
@@ -14,32 +14,32 @@ module.exports = GeoJSON = {};
GeoJSON.Geometry = {
'type': { type: String, required: true, enum: ["Point", "MultiPoint", "LineString", "MultiLineString", "Polygon", "MultiPolygon"] },
- coordinates: [Object]
+ coordinates: []
}
GeoJSON.Point = {
'type': { type: String, required: true, default: "Point" },
- coordinates: [Number]
+ coordinates: []
};
GeoJSON.MultiPoint = {
'type': { type: String, required: true, default: "MultiPoint" },
- coordinates: [Array]
+ coordinates: []
};
GeoJSON.MultiLineString = {
'type': { type: String, required: true, default: "MultiLineString" },
- coordinates: [Array]
+ coordinates: []
}
GeoJSON.Polygon = {
'type': { type: String, required: true, default: "Polygon" },
- coordinates: [Array]
+ coordinates: []
};
GeoJSON.MultiPolygon = {
'type': { type: String, required: true, default: "MultiPolygon" },
- coordinates: [Array]
+ coordinates: []
};
GeoJSON.GeometryCollection = {
from mongoose-geojson-schema.
@markstos mongoose 4.0.3, mongodb 2.6.9...still experiencing this issue. The fix to allow validation would to use the Schema.Types from mongoose, which would require adding that dependency. Without, we have to use an empty array, which falls back on a Mixed type. Will you accept a pull request that essentially does what @heatmonkey proposed, or do you have another fix for this issue?
from mongoose-geojson-schema.
@mmacmillan I don't mind adding a dependency, if we can fix this and still have validation.
I don't have an alternate fix for this.
from mongoose-geojson-schema.
This should be fixed by the 1.0.0 release, thanks to @joshkopecek
Notice the syntax is slightly different, so it's not a drop-in upgrade.
Re-open if you still see an issue with the 1.0 release.
from mongoose-geojson-schema.
Related Issues (20)
- CastError surfacing still an issue HOT 3
- Can't use $geoIntersects HOT 1
- Correct way to 2dsphere index when using these schema
- Can't query using `$nearSphere` because of model validation of query object HOT 2
- Add "schemaName" to each of the SchemaTypes HOT 1
- Typeerror: GeoJSON is not a constructor HOT 1
- nullable field HOT 6
- The cast function doesn't take JSON into consideration HOT 2
- Cannot create type point with point array HOT 2
- Typescript definition HOT 4
- Does not work with mongoose 5.x HOT 1
- Failing to validate a GeometryCollection inside a Feature HOT 4
- add pure export
- Passing NaN as point coordinates should fail HOT 6
- Conflicts on typescript compile HOT 2
- Remove `@types/mongoose` dependency HOT 1
- Feature.properties should be mandatory HOT 2
- Open to PRs? HOT 30
- specific errors are not available when validation fails HOT 1
- GeoJSON type HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mongoose-geojson-schema.