Giter VIP home page Giter VIP logo

Comments (6)

mdanish98 avatar mdanish98 commented on July 30, 2024

Hi @SebBehrendt

Thanks for raising this issue.
We will check and get back to you.

from basyx-java-server-sdk.

FrankSchnicke avatar FrankSchnicke commented on July 30, 2024

When using the JSON serialization of AAS4J, it is internally mapped to CamelCase (cf. here) which is consistent with the specification (cf. Specification of the Asset Administration Shell Part 2, p. 168).

Are you using the official SwaggerHub specifications (e.g., here) for code generation?

from basyx-java-server-sdk.

SebBehrendt avatar SebBehrendt commented on July 30, 2024

Hello,

thank you for the replies. The serialization is done correctly to CamelCase in the RestAPI. However, the openAPI-Specification (of the java-server-sdk at /v3/api-docs) denotes the enum values as fully capitalized.

In the official documentation, the Enum Values of KeyTypes are also fully capitalized (https://app.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.0.1#/components/schemas/ReferenceTypes, line 535ff). I think this is probably the reason for the capitalized values...

As far as I understand it, this should be also CamelCase as the official documentation specifies, correct?

from basyx-java-server-sdk.

FrankSchnicke avatar FrankSchnicke commented on July 30, 2024

Yes, this might be an issue in the OpenAPI specification. There's an official repo of IDTA for that:
https://github.com/admin-shell-io/aas-specs-api

Feel free to raise an issue there.

from basyx-java-server-sdk.

arteeh avatar arteeh commented on July 30, 2024

In the official documentation, the Enum Values of KeyTypes are also fully capitalized (https://app.swaggerhub.com/domains/Plattform_i40/Part1-MetaModel-Schemas/V3.0.1#/components/schemas/ReferenceTypes, line 535ff). I think this is probably the reason for the capitalized values...

I don't see capitalized values on line 535. Has this been fixed on the IDTA end? I couldn't find any related issues or PRs in https://github.com/admin-shell-io/aas-specs-api.

If this has been fixed, I assume this will end up in BaSyx in a future snapshot / release?

from basyx-java-server-sdk.

SebBehrendt avatar SebBehrendt commented on July 30, 2024

Hello,

you are correct. In the official documentation (e.g. in line 535), the enum values are correctly specified as camel case values. I think the only problem is, that the java server sdk specifies in its openAPI specification that enum values are fully capitalized (which is inconsistent with the actual API).

from basyx-java-server-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.