Comments (22)
Just some usual statistic:
Previous build times where around 35 minutes we are now at around 30 minutes, so not that bad, but on a 16 CPU machine with parallel builds I could get a buildtime of the whole equinox of Total time: 09:33 min (Wall Clock) without any special optimization!
So if we are really concerned about build times we:
- use parallel builds as much as possible
- parallelize tests, in my run the test execution takes 08:03 min so if we can distribute and/or parallelize the execution this will has direct impact on the overall build time!
- ask EF Infra to cache maven downloads (it seems currently it downloads over and over again...)
- ask EF Infra to give us more CPU power on the executors
from equinox.bundles.
It should be possible to simply push the PR to the new remote? But anyways we can wait if there is a ETA and we do not delay it one more release I think.
from equinox.bundles.
@vogella Please do so. We have to act as we are just spinning here while actual problems are pending and depend (in a way ) on that - #54 (comment)
from equinox.bundles.
We are doing the same for PDE eclipse-pde/eclipse.pde#35
from equinox.bundles.
@tjwatson please approved. Worked well for pde.ui to pde
from equinox.bundles.
@vogella @tjwatson any progress here? Will the merge happen after 2022-06 release?
from equinox.bundles.
@vogella @tjwatson any progress here? Will the merge happen after 2022-06 release?
That's the plan as far as I know.
Renaming is planned after the merge with equinox.framework (eclipse-equinox/equinox.framework#14) which is just waiting for eclipse-equinox/equinox.framework#44. The latter is waiting for a release of felix-scr: eclipse-equinox/equinox.framework#44 (comment)
But @tjwatson expressed the intention to perform the release soon.
from equinox.bundles.
Why is any of those required to merge git repositories?
from equinox.bundles.
It is not required. @vogella probably just wanted to be so kind to avoid the extra work to re-create PRs.
But its statement was from a time where more where open. One PR does not justify a longer delay.
Maybe @tjwatson could give an ETA for the FELIX-SCR release? If that is not too far it would be nice to wait another week or so. :)
from equinox.bundles.
@tjwatson you stay very quit here :-) Can you share you go or no-go for the rename of the repo. We did it in PDE (pde.ui to pde) and IIRC we had no (or at least only little so I forgot them) issues with it.
from equinox.bundles.
Last discussion we had I thought we were leaving both repos as is and creating a new one called equinox
to merge framework and bundles into. Then convert the existing repos to read-only with a final commit that removes everything except a readme pointing to the new repo.
from equinox.bundles.
Sounds good. Shall I open a help desk request to create a new repo or do you want to do this?
from equinox.bundles.
@vogella Please do so. We have to act as we are just spinning here while actual problems are pending and depend (in a way ) on that - #54 (comment)
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1416
from equinox.bundles.
@akurtakov done, and I pushed content of equinox.bundles to the new equinox repo. https://github.com/eclipse-equinox/equinox
Can someone update the aggegator build and close all pending PR of equinox-bundles? This process would be less disruptive if we renamed the old repo.
from equinox.bundles.
@vogella what about the framework repo? Just in case we adjust the aggregator so no need for double work?
from equinox.bundles.
@merks would you be so kind adjusting the setup (maybe after @vogella also moved the framework repo)
from equinox.bundles.
@vogella what about the framework repo? Just in case we adjust the aggregator so no need for double work?
@laeubi can you provide a merge PR for it?
from equinox.bundles.
Yes, I've been following this thread and as soon as the framework repo is merged in I can merge the two setups.
from equinox.bundles.
From releng POV I would like to do the aggregator build changes once as we all have an agreement let's just act on it.
from equinox.bundles.
Master build is running fine now: https://ci.eclipse.org/equinox/job/equinox/job/master/ so I would assume my part is done here :-)
from equinox.bundles.
@laeubi So I should look to make the setup work now?
from equinox.bundles.
At least everything from both repos is in, so from eclipse ide side we should be fine 👍
from equinox.bundles.
Related Issues (15)
- There is a new test fail caused by this change, tests must be updated too. HOT 2
- -Dosgi.dataAreaRequiresExplicitInit=true doesn't work anymore HOT 5
- Publish the a "BundleStateScope" as an IScopeContext service (factory)
- Build failure in 4.24 I-Build: I20220428-0120 HOT 5
- java.lang.IllegalArgumentException: Declaration is invalid in recent builds HOT 4
- org.eclipse.equinox.preferences has wrong version HOT 6
- Enable Discussions? HOT 2
- Storage location for ConfigAdmin HOT 9
- logback RCE CVE-2021-42550 HOT 7
- Incorrect `org.osgi.service.prefs` dependency in org.eclipse.equinox.preferences-3.10.0 HOT 68
- org.osgi.service.prefs.Preferences cannot be resolved. It is indirectly referenced from required .class files HOT 2
- Archive this repository HOT 9
- UnsupportedClassVersionError due to fix on org.osgi.service.prefs HOT 11
- org.eclipse.equinox.http.jetty has 1 resolution problems.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from equinox.bundles.