Comments (5)
billlamiework
commented on May 28, 2024
LDREX and STREX are being used for the locking mechansim. Are you suggesting additional locations?
from threadx.
junomoto
commented on May 28, 2024
Yes.
Three locations accesses "_tx_thread_smp_protection.tx_thread_smp_protect_in_force".
One lcation is using LDREX and STREX.
But, other two location aren't using.
from threadx.
billlamiework
commented on May 28, 2024
Since I last looked at this code some queuing logic was also added. In some of the other SMP port-specific code, the queuing logic was then removed. More investigation is needed to find the correct fix (which may include the removal of the queuing logic) as well as make sure _tx_thread_smp_protection.tx_thread_smp_protect_in_force is accessed properly. Are you actually experiencing a problem with the code, and do you currently have a fix?
From: junomoto ***@***.***>
Sent: Monday, February 19, 2024 4:25 PM
To: eclipse-threadx/threadx ***@***.***>
Cc: Bill Lamie ***@***.***>; Comment ***@***.***>
Subject: Re: [eclipse-threadx/threadx] tx_thread_smp_protect (Issue #360)
Yes.
Three locations accesses "_tx_thread_smp_protection.tx_thread_smp_protect_in_force".
One lcation is using LDREX and STREX.
But, other two location aren't using.
β
Reply to this email directly, view it on GitHub<#360 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDUEV3H6XMOD5CNTPXHRDCTYUPUMNAVCNFSM6AAAAABDLOVZP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGMYDQNBSG4>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
from threadx.
junomoto
commented on May 28, 2024
I'm not good at English.
Sorry if I've made a mistake.
I found a problem.
TX_MPCORE_DEBUG_ENABLE is enabled.
Thread0 is fixed only core0.
Thread0 by core0 can't get _tx_thread_smp_protection.tx_thread_smp_protect_in_force, and enter a loop.
_tx_thread_smp_protection.tx_thread_smp_protect_thread is thread0.
But, _tx_thread_smp_protection.tx_thread_smp_protect_core is core1.
I predicted.
core0 got _tx_thread_smp_protection.tx_thread_smp_protect_in_force.
core1 waited getting it.
If core0 release it and try to get again at soon.
core0 and core1 gets it at same time.
So, they need using LDREX and STREX.
That code I pasted is already fixed.
from threadx.
billlamiework
commented on May 28, 2024
Your English is good, and I'm happy to hear everything is working. I recommend issuing a pull request with your fix so it gets properly reviewed.
from threadx.
Related Issues (20)
- Threadx on Microblaze soft processor HOT 1
- Why EPK kit is not supported in ThreadX release 6.3.0? HOT 1
- on riscv archοΌ does the user creat thread code run on machine mode
- Is it possible to provide Cortex-M code in ports_smp? HOT 1
- Is it possible to register a notification callback when using tx_trace_user_event_insert? HOT 1
- Register RA will be modified when TX_ENABLE_EXECUTION_CHANGE_NOTIFY is enabled HOT 1
- Potentially missing null check for thread pointer in _tx_mutex_get() HOT 1
- __tx_ts_wait will loop forever (threadx-6.2.1_rel\ports\cortex_m33\gnu\src\tx_thread_schedule.S) HOT 1
- Repeating error codes in common/inc/tx_api.h HOT 6
- on riscv32, Does flow situation use right?
- _tx_semaphore_created_ptr is always NULL HOT 3
- The interrupt vector table offset register should not be set.
- tx_byte_pool service fragmentation problem HOT 3
- How to include threadx in the project via CMake system? HOT 2
- Dose threadx module has 'who am I' utility?
- Certification Package for Eclipse ThreadX HOT 2
- ULONG == uint32_t in 64-bit system cause problem HOT 1
- Fix CMake minimum require version warning
- Cortex-M7 : Is _tx_thread_context_save/_tx_thread_context_restore required in interrupts? HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from threadx.