SortedSet#intersect does not always return elements from this about eclipse-collections HOT 2 OPEN

Hi! I think we might be able to fix this issue by gently removing this part of the optimization code in https://github.com/eclipse/eclipse-collections/blob/master/eclipse-collections/src/main/java/org/eclipse/collections/impl/utility/internal/SetIterables.java#L77-L82

from eclipse-collections.

It makes sense to me. I'd like to get @mohrezaei's opinion too since there was a similar change in #1661 that raised performance concerns.

from eclipse-collections.

So clearly the behavior and the doc are inconsistent. It should be noted that this can only happen if the set's sense of equality is different from whatever way the returned set's elements are being compared to elements from this.

So there are two ways to fix this:

1. Keep the doc, change the behavior. This would get rid of the optimization.
2. Keep the behavior, fix the doc.

I would generally favor (2), for the following reasons:

• the only real benefit of this funciton is that bit of optimization. It's otherwise just an alias for a one-liner.
• these functions (intersect, difference, etc) are borrowed from set-theory, where set elements don't have different senses of equality.

We could even be very explicit in the doc and suggest using this.select(that.contains) if someone has the requirement to preserve the memory references from this.

from eclipse-collections.