Comments (2)
rohanKanojia
commented on September 27, 2024
1
@Adityaturkhade You would need to add a new field Map<String, String> nodeSelectors in ControllerResourceConfig.
This field would be read in PodTemplateHandler that would set .withNodeSelector() builder method in createPodSpec with value set in this field.
A similar field schedule was added to ControllerResourceConfig in this pull request #2012
Apart from making these changes, you would need to:
- Add unit tests verifying your change is working
- Add documentation for this new field
- Add integration test verifying setting
nodeSelectorin Groovy DSL config is modifying resources . See similar pull request #2121
from jkube.
Adityaturkhade
commented on September 27, 2024
I would like to pick this issue but I need some help and elaboration
from jkube.
Related Issues (20)
- MojoExecutionService 'goal.length() > 0' can be replaced with '!goal.isEmpty()' HOT 3
- OpenShiftBuildServiceUtils 'nocache.length() == 0' can be replaced with 'nocache.isEmpty()' HOT 3
- RegistryConfigTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 3
- JKubeConfigurationTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 3
- ControllerResourceConfigTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 4
- KubernetesSshServiceForwarderTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 1
- JibServiceUtilTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 2
- Replace `maven-failsafe-plugin`'s deprecated `systemProperties` configuration field with `systemPropertyVariables` HOT 1
- PluginServiceFactory 'line.length() > 0' can be replaced with '!line.isEmpty()'
- RegistryAuthConfiguration 'content[i + 1].length() > 0' can be replaced with '!content[i + 1].isEmpty()' HOT 1
- UrlBuilder 'queryParams.size() > 0' can be replaced with '!queryParams.isEmpty()' HOT 1
- WebServerEventCollector 'evts.size() > 0' can be replaced with '!evts.isEmpty()' HOT 1
- ImageNameTest: Unnecessary 'toString()' call HOT 2
- KarafHealthCheckEnricher: Unnecessary 'toString()' call
- HelmServiceInstallIT is failing on Windows HOT 1
- DeploymentConfigHandlerTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 1
- KubernetesResourceUtilTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 2
- ProbeHandlerTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 1
- ServiceHandlerTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))` HOT 1
- CronJobHandlerTest : Replace AssertJ's deprecated `asList()` DSL method with `asInstanceOf(InstanceOfAssertFactories.list(type.class))`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jkube.