Using property `jkube.enricher.jkube-name.name` overrides the names set in the resources fragments about jkube HOT 4 OPEN

@amihalfa : Is it possible for you to debug this to check what's wrong with Enricher behavior?

1. Set a breakpoint in Enricher
2. Run mvnDebug k8s:resource from terminal
3. Connect Via Remote JVM Debug from your IDE

I see that in code we're only setting name when it's blank:

from jkube.

Hello @rohanKanojia

When I debug :

• configuredName has the value set in my pom.xml
• defaultName has the value of my ${project.artifactId}

The resource name is always overwritten if a configuredName is set. From my point of view, if the resource already has a name, we keep the name, even if there is a configuredName.

My expected behaviour is to have in NameEnricher something like this :

        builder.accept(new TypedVisitor<ObjectMetaBuilder>() {
            @Override
            public void visit(ObjectMetaBuilder resource) {
                if (StringUtils.isBlank(resource.getName())) {
                    if (StringUtils.isNotBlank(configuredName)) {
                        resource.withName(configuredName);
                    } else {
                        resource.withName(defaultName);
                    }
                }
            }
        });

Thanks !

from jkube.

@amihalfa : Your approach looks correct to me. Is it possible to contribute a pull request for this?

from jkube.