Comments (4)
Another note:
This is, of course, only necessary if the additionalTextEdits have a start offset that is greater than the cursor position (at the time of requesting the completion proposals).
AdditionalTextEdits that appear before the current cursor position (e.g. automated insertion of new import statements) work nicely, of course.
from lsp4e.
Actually, I debugged through the code a bit and it looks like there is code already to adjust the AdditionalTextEdits - and it looks like this adjustment is actually the problem... :-)
The additional text edit contains a line number and a character number in that line. So as long as the additional text edit is on a different line than the completion happened, the adjustment does NOT need to happen - at least this is what is looks like to me.
from lsp4e.
@vrubezhny I saw you implemented the related code in 9915647, do you remember the exact use case you had for this? Seems like I need to understand this in more detail
from lsp4e.
Fixes with #897
from lsp4e.
Related Issues (20)
- deadlock i think in lsp4e code for markers, (deadlock in the workspace lock) HOT 2
- Folding reconciler is not invoked when document changes
- Enable folding via preferences
- Exception in LSPEclipseUtils.applyEdits
- Master build broken due to failed unit test HOT 6
- Performance issue when formatting a large file
- Folding annotations gets removed on large files while editing
- SimRel Participation? HOT 13
- MicroProfileGenerateOpenAPIOperation code action breaks developer workflow HOT 1
- Add References to editor context menu HOT 3
- Support partial results for DocumentSymbol
- Add ID to menu to allow external contributions
- CTRL+SHIFT+T conflict HOT 4
- Remove end slash from rootPath / rootUri / workspaceFolders
- Semantic Tokens support HOT 3
- Open Declaration (Ctrl + Click / F3) does not collect declarations
- Hovering over Maven elements perhaps needs longer timeout
- The default label for multiple declarations is not useful HOT 11
- LSPEclipseUtils.FILE_URI should be 'file:' instead of 'file://' HOT 2
- Inline type hints are missing spacing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lsp4e.