adjustments to additionalTextEdits are slightly off when on different line (when applying a proposal) about lsp4e HOT 4 CLOSED

Another note:
This is, of course, only necessary if the additionalTextEdits have a start offset that is greater than the cursor position (at the time of requesting the completion proposals).

AdditionalTextEdits that appear before the current cursor position (e.g. automated insertion of new import statements) work nicely, of course.

from lsp4e.

Actually, I debugged through the code a bit and it looks like there is code already to adjust the AdditionalTextEdits - and it looks like this adjustment is actually the problem... :-)

The additional text edit contains a line number and a character number in that line. So as long as the additional text edit is on a different line than the completion happened, the adjustment does NOT need to happen - at least this is what is looks like to me.

from lsp4e.

@vrubezhny I saw you implemented the related code in 9915647, do you remember the exact use case you had for this? Seems like I need to understand this in more detail

from lsp4e.

Fixes with #897

from lsp4e.