Comments (4)
mnwhite
commented on August 9, 2024
I'd have to see if this is intentional or just a weird oversight. I don't
think it's a bug, just an odd choice.
Init is something that should be standardized across AgentTypes. That's
part of what I'm working on.
…On Sat, Apr 6, 2024, 6:54 PM Alan Lujan ***@***.***> wrote:
https://github.com/econ-ark/HARK/blob/3ee397993a1db76bbc9ae24d3196dc31ccfe4874/HARK/ConsumptionSaving/ConsIndShockModel.py#L3347
KinkedR inherits from IndShockConsumerType
https://github.com/econ-ark/HARK/blob/3ee397993a1db76bbc9ae24d3196dc31ccfe4874/HARK/ConsumptionSaving/ConsIndShockModel.py#L3369
But init's from PerfForesightConsumerType
is this a bug? does it make a difference?
—
Reply to this email directly, view it on GitHub
<#1406>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFPVBYFXJF35CI4B37TY4B4JRAVCNFSM6AAAAABF2Y5G7WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDSNBVGE3DKMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from hark.
alanlujan91
commented on August 9, 2024
I guess my question is why type the class name at all instead of super().__init__(**params) or for other methods across the codebase typing parent_class_name.method(self) instead of super().method(). It's not like we're doing a lot of double inheritance, and it would prevent these errors from happening since it always knows the right parent.
from hark.
mnwhite
commented on August 9, 2024
Oh, it might have been an oversight when programming it. Or there's some
subtle reason to call PF's init rather than ConsIndShock-- I'm not sure.
But either way, this is part of the "spaghetti inheritance" problem that
we're unwinding.
…On Sat, Apr 6, 2024, 7:06 PM Alan Lujan ***@***.***> wrote:
I guess my question is why type the class name at all instead of
super().__init__(**params) or for other methods across the codebase
typing parent_class_name.method(self) instead of super().method(). It's
not like we're doing a lot of double inheritance, and it would prevent
these errors from happening since it always knows the right parent.
—
Reply to this email directly, view it on GitHub
<#1406 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKRAFPAO4WIUEAUFH3K4PTY4B5V3AVCNFSM6AAAAABF2Y5G7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGIZDOMRSGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
from hark.
alanlujan91
commented on August 9, 2024
please see PR #1407
replaced references to parent class with super
also removed some redundant calls to construction
there is one check failing which is concerning me, because I don't think I changed anything substantive, which makes me think there might have been a bug due to the spaghetti inheritance
from hark.
Related Issues (20)
- YAML config file to New Python Model Format (NPMF)
- NPMF for ConsIndShock HOT 6
- utilities.py: metadata bug in make_figs() HOT 7
- IndexError when solving ConsPortfolioModel HOT 2
- PermShk's are not random enough HOT 2
- We should not use both `seed` and `RNG`. HOT 4
- ImportError: cannot import name 'generated_jit' from 'numba' HOT 4
- Module not found... numpy? HOT 6
- calc_stable_points is being run when it shouldn't be
- ConsBequestModel and related example notebooks HOT 1
- Improve contributor guide with respect to API documentation
- What is update? How many terminal solutions? HOT 8
- Proposed constructed input framework HOT 11
- Make sure our links are updated to the new doc website
- Should pytest be a requirement? HOT 3
- IndShockConsumerType.calc_jacobian() changes cFunc_terminal_ HOT 4
- Why does PerfForesightLabeled inherit from ConsIndShock? HOT 7
- DeprFac should be DeprRte
- remove FrameAgentType; transfer diagramming functionality over to new Block framework
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hark.