Giter VIP home page Giter VIP logo

Comments (5)

Eahlstan avatar Eahlstan commented on June 3, 2024

If you delete commanders in the settings you're telling EDD that you don't want to see it ever again, hence the events linked to it now are linked to nothing and thus only visible in the hidden log. (I was wrong on that, they are still there but aren't shown anywhere, not even in the hidden log.) The events are still in the DB and thus rereading has no effect, if something shows up in the hidden log it's either because you moved it there or a broken journal was imported. No matter how hard I try rereading journals put nothing in the hidden log, no matter if the commander is soft deleted on the settings panel or hard deleted in the DB.
Not a bug.

from eddiscovery.

dymm2000 avatar dymm2000 commented on June 3, 2024

How to recreate cmdr without delete db? Since this db also contains general UI settings

from eddiscovery.

klightspeed avatar klightspeed commented on June 3, 2024

If I recall correctly, the delete is a soft delete (i.e. setting Deleted=true). Deleting a commander shouldn't immediately move all history entries from that commander ID to the hidden logs commander ID, and unless and until you perform other actions undeleting them should only require setting Deleted=0 on that commander in the database.

"Reset all history to current commander" will have moved all history to the current commander, regardless of what commander it was linked to beforehand.

Fortunately resetting the commander ID on the journal entries does not reset the commander ID on the travel log units (i.e. references to journal files). This does present a potential lifeline:

  1. Close EDDiscovery
  2. Take a backup of the database
  3. Open the database in e.g. DB Browser for SQLite
  4. Set the Commander Deleted to false
  5. Update the CommanderId on the journal entries back to the CommanderId on the travel log units

Or you could take the nuclear approach, and:

  1. Close EDDiscovery
  2. Take a backup of the database
  3. Open the database in e.g. DB Browser for SQLite
  4. Truncate both the Commanders and TravelLogUnit tables
  5. Re-open EDDiscovery
  6. Re-read all of your journals

edit: though looking at your other issues, the fact that you're expecting to be able to fetch logs from EDSM suggests that you don't have those journals, and you have more to clean up than just the journals in the database.

from eddiscovery.

Eahlstan avatar Eahlstan commented on June 3, 2024

If I recall correctly, the delete is a soft delete (i.e. setting Deleted=true). Deleting a commander shouldn't immediately move all history entries from that commander ID to the hidden logs commander ID, and unless and until you perform other actions undeleting them should only require setting Deleted=0 on that commander in the database.

This seems to be a rare case of you misunderstanding the issue.

This user wiped his EDSM data (on the website), wondered why EDD didn't resync every single event (how should EDD know EDSM was wiped?), then deleted the commander in the settings panel (which only "hides" the commander) then got angry that EDD didn't reread his journals (because of course they are still in the DB) finally nuked his DB (because in the version of the wiki at this time "delete commanders & journals" wasn't mentioned - only "delete journals" was - which doesn't seem to be enough to even open the safe mode menu for this user (if he even read that thing)), rebuilt the user DB, saw that in EDD everything was alright but on EDSM it wasn't, got angry again and blamed EDD for either an EDSM error or his impatience to let EDD finish syncing to EDSM. Unfriendly issue spam instead of a civil help request.

There never was an EDD error, nor was there a request for undeleting a deleted commander. But yes: It's just "Deleted = 1" in the Commanders table, so it's easy to "restore" it by editing that field in the DB.

from eddiscovery.

Eahlstan avatar Eahlstan commented on June 3, 2024

Not that there isn't an issue involved: EDD gracefully crashes when deleting the currently active commander, but that wasn't even mentioned in any of the issues.

from eddiscovery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.