Get command should return server error instead of timeout error about device-onvif-camera HOT 4 CLOSED

@weichou1229 seems like a 503 - Service Unavailable is the right code, but the message is the problem? Also 502 or 504 could potentially be used as well, but 503 probably makes the most sense.

from device-onvif-camera.

@ajcasagrande

seems like a 503 - Service Unavailable is the right code

Yes, the 503 is right.

I thought the problem is we used 5s to create a new Onvif client. The HTTP request already timeout on the service level even if the Onvif client threw the unavailable error.

service HTTP timeout

  Service:
    ...
    RequestTimeout: "5s"

https://github.com/edgexfoundry/edgex-go/blob/0d6a49cb75d16cdeffa3d89b53872b828db0197b/cmd/core-common-config-bootstrapper/res/configuration.yaml#L31

Onvlif client timeout

# Custom configs
[AppCustom]
# The number of seconds to wait when making an Onvif request before timing out
RequestTimeout = 5 # Seconds

from device-onvif-camera.

@ajcasagrande This issue cause the automation test case failed. May we set the default AppCustom.RequestTimeout config to 4 (less than the service request tmieout)? Then, the service can reply the proper error content in the response. If you agree with this solution, I can assign someone to work on it. Thanks.

from device-onvif-camera.

@cloudxxx8 yes that is fine

from device-onvif-camera.