Validation prevents device services from being referenced by name when part of another object's JSON about go-mod-core-contracts HOT 6 CLOSED

core-metadata logs

level=ERROR ts=2019-05-02T15:23:59.724796665Z app=edgex-core-metadata source=rest_device.go:61 msg="invalid OperatingState \"\""

and returns HTTP 400 with the message

invalid OperatingState ""

from go-mod-core-contracts.

Related blackbox test PR edgexfoundry/blackbox-testing#207

from go-mod-core-contracts.

@tsconn23 this issue is blocking the Device Services working with core-metadata, including the new black box test of virtual device service. May we merge the fix made by @iain-anderson first?
add @cherrycl , @FelixTing for awareness

from go-mod-core-contracts.

@iain-anderson @tsconn23 @cloudxxx8 Replace value receiver with pointer receiver can fix this bug.

func (as *AdminState) Validate() (bool, error) {
	_, found := map[string]AdminState{"LOCKED": Locked, "UNLOCKED": Unlocked}[string(*as)]
}

see my PR-#90

from go-mod-core-contracts.

@iain-anderson @tsconn23 @cloudxxx8 I'm having the same problem. I fix invalid OperatingState "", but the problem with json formatting cascading, however, is that when adding a device, i must specify the address name or id of the device service. Now i can only remove the code of verify the addressable to add the device successfully.
if not it will return Addressable ID and Name are both blank, which is address of DeviceService.
so i have to add the field address of DS as following show:

{
	"name":"mqtt-device-01",
	"adminState":"UNLOCKED",
	"operatingState":"ENABLED",
	"protocols":{
	},
	"service":{
		"name":"localhost",
		"addressable":{
			"name":"xxx"
		}
	},
	"profile":{
		"name":"test-mqtt-profile"
	}
}

or i remove the Validate code in the Addressable model :

func (a Addressable) Validate() (bool, error) {
	if !a.isValidated {
		// if a.Id == "" && a.Name == "" {
		// 	return false, NewErrContractInvalid("Addressable ID and Name are both blank")
		// }
		return true, nil
	}
	return a.isValidated, nil
}

from go-mod-core-contracts.

Merged PR #86. See my comment there. In my opinion, this is indicative of a larger refactoring effort that needs to be done.

from go-mod-core-contracts.