Giter VIP home page Giter VIP logo

Comments (2)

generalmimon avatar generalmimon commented on May 20, 2024 2

Yeah, currently only the last -exclude setting gets picked up and any previous setting is silently ignored (NB: no \.rb$ in "Exclude Regexp"):

$ ec -verbose -exclude '\.rb$' -exclude '\.gemspec$'
Exclude Regexp: \.gemspec$|^\.yarn/|^yarn\.lock$|^package-lock\.json$|^composer\.lock$|^Cargo\.lock$|^Gemfile\.lock$|^\.pnp\.cjs$|^\.pnp\.js$|^\.pnp\.loader\.mjs$|\.snap$|\.otf$|\.woff$|\.woff2$|\.eot$|\.ttf$|\.gif$|\.png$|\.jpg$|\.jpeg$|\.webp$|\.avif$|\.mp4$|\.wmv$|\.svg$|\.ico$|\.bak$|\.bin$|\.pdf$|\.zip$|\.gz$|\.tar$|\.7z$|\.bz2$|\.log$|\.patch$|\.css\.map$|\.js\.map$|min\.css$|min\.js$

Ironically, this project's own Makefile doesn't account for this either:

run: build ## Build and run bin/ec
@./bin/ec --exclude "\\.git" --exclude "\\.exe$$"
run-verbose: build ## Build and run bin/ec --verbose
@./bin/ec --verbose --exclude "\\.git" --exclude "\\.exe$$"

It would be great if multiple -excludes were all picked up and merged into the regexp as alternatives (like the Exclude array in JSON configuration), as many of us would intuitively expect. An inferior alternative (but still better than the current silent "last wins" overwrite) would be to detect multiple -exclude settings and inform the user that only the last one was applied - but I guess that the proper fix of just adding support for multiple -excludes would actually be easier to implement than this ;)

from editorconfig-checker.

mstruebing avatar mstruebing commented on May 20, 2024

Anyone willing to create a PR for this?

from editorconfig-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.