editorconfig is breaking the detectIndentation on vscode about editorconfig-vscode HOT 8 CLOSED

Fixed in #70

from editorconfig-vscode.

Is there any way to get the EditorConfig plugin to override the VS Code settings for indentation? Isn't that the whole point of this plugin?

from editorconfig-vscode.

Sorry you're having this issue! Thanks for the steps to reproduce. I'm definitely not going to have any time to fix the issue this week, but I maybe the following week.

Also, I'm accepting pull requests, so if you have a fix then I will gladly merge and publish.

from editorconfig-vscode.

Yep having the same problem, very annoying. I want use editorconfig for other things but it totally breaks the indentation detection.

from editorconfig-vscode.

Can you show me what your .editorconfig file looks like? And tell me what file names are showing the issue?

from editorconfig-vscode.

I am definitely seeing the problem on .cpp, .h, .py files I didn't test any others
Below is my current .editorconfig file

[*]
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false

from editorconfig-vscode.

Aha, so you don't actually have any indentation settings at all and the plugin is still intercepting the native indentation detection? This helps a lot!

from editorconfig-vscode.

I'm seeing this, as well. My suspicion--from scanning the code--is that this plugin is merging the VS Code defaults (via DocumentWatcher#getDefaultSettings) with a blank config provided by editorconfig.parse when either

• there is no .editorconfig in any ancestor folder (my case)
• there is no matching .editorconfig spec for the provided filepath (@mschuckmann's case, if I read correctly)

I think a viable fix might be to not set this line if the options provided from editorconfig.parse doesn't explicitly specify tab/space settings (i.e. if both insertSpaces and tabSize are being defaulted).

But I'm not super familiar with VS Code extensions 😅

from editorconfig-vscode.