v0.3.4 highlights final newline after save about editorconfig-vscode HOT 7 CLOSED

unless you listen for the onDidSaveTextDocument event

That's how it should be done. https://github.com/SamVerschueren/vscode-final-newline/blob/master/extension.ts#L65

from editorconfig-vscode.

This is expected behavior, see #40. This makes sure that the selection is set back to what it was before the save. This this works as well with multiple cursors and multiple selections. It does break intellisense however, but that can't be solved as long as it is not supported in VS Code core.

from editorconfig-vscode.

@SamVerschueren, this issue is a different one. The selection is NOT set to what it was before, because it has the final newline selected (highlighted). See the following screen capture:

If my cursor is anywhere else in the file when I trigger a save then it doesn't happen, but if my cursor is already on the very last character of the file, that's when it happens.

from editorconfig-vscode.

Oh you're right! Thanks for elaborating. Didn't add the put back part yet. This is odd. Should we implement to put back the selections after save then?

from editorconfig-vscode.

I tried to do that myself, but I wasn't having success and was running out of time so I reverted my changes. But yes, I do think we should restore the selections, if possible. The problem is that the TextEdit[] is not actually, itself, a Thenable<T>, so you can't really control the restoration of the selections unless you listen for the onDidSaveTextDocument event, so it gets pretty dirty. e.waitUntil(...) returns void, so you can't do a .then() on that either. It's frustrating.

from editorconfig-vscode.

BTW, this also happens with multiple cursors, but only when one of those cursors is at the very end of the file.

from editorconfig-vscode.

Fixed and published in version 0.6.2!

from editorconfig-vscode.