Strict aliasing violation warning about tlse HOT 8 CLOSED

Thanks, I'll take a look. memcpy sounds ok, but it guess it will be slow (compared with a simple attribution). I'll rewrite those lines, thanks for reporting.

from tlse.

Not sure though if you want to use our solution but we've resolved this in ltc like this

from tlse.

No, it won't be any slower. memcpy with short, constant sizes will be inlined by the compiler, yielding the same machine code as cast/assign.

https://godbolt.org/g/zGEGLb

from tlse.

Most lines can be simply rewritten as:

*(int *)&trail[4] => *(int *)(trail + 4)

from tlse.

A kind of cosmetic patch:

alias.txt

from tlse.

Tried, patch failed:

Patching file tlse.c using Plan A...
Hunk #1 succeeded at 809 (offset 9 lines).
Hunk #2 succeeded at 3760 (offset 408 lines).
Hunk #3 FAILED at 3393.
Hunk #4 succeeded at 6681 (offset 983 lines).
Hunk #5 FAILED at 6505.
Hunk #6 FAILED at 6520.
Hunk #7 FAILED at 6562.
Hunk #8 FAILED at 6593.
Hunk #9 succeeded at 7861 (offset 1186 lines).
5 out of 9 hunks FAILED -- saving rejects to file tlse.c.rej
done

from tlse.

The patch was made against f162e06. I do not use your master for now as having some local mods (tls_peek, another tls_pending, etc.), not sure if you are interested in them

from tlse.

Fixed (based on your patch). Thanks!

from tlse.