Giter VIP home page Giter VIP logo

Comments (9)

rxkevin avatar rxkevin commented on May 23, 2024 1

I'm short on time but I will try to make it this week hopefully.

from react-inputs-validation.

RokasAnisas avatar RokasAnisas commented on May 23, 2024 1

It does! We can close this issue now.

from react-inputs-validation.

edwardfxiao avatar edwardfxiao commented on May 23, 2024

Hi @rxkevin, I have updated the version to 4.6.0, not sure if it works, can you check it out?

from react-inputs-validation.

rxkevin avatar rxkevin commented on May 23, 2024

First of all, forgot to mention, good work on this package!

One step closer, types are now included in the package, however, index.d.ts must be in the root of your package, where now it is in the root/lib directory. As mentioned, you will probably need to modify your build script, or set "declarationDir": "./" in tsconfig.

Screenshot 2020-12-02 at 09 17 41

from react-inputs-validation.

rxkevin avatar rxkevin commented on May 23, 2024

Also, type definitions could be improved for each component. A lot of parameters use abstract types, which is not that helpful either.

Screenshot 2020-12-02 at 09 22 32

from react-inputs-validation.

edwardfxiao avatar edwardfxiao commented on May 23, 2024

Is it possible that you can create a PR for this?

from react-inputs-validation.

edwardfxiao avatar edwardfxiao commented on May 23, 2024

Does v4.6.2 meet the expectation?

from react-inputs-validation.

edwardfxiao avatar edwardfxiao commented on May 23, 2024

@all-contributors please add @RokasAniss for code

from react-inputs-validation.

allcontributors avatar allcontributors commented on May 23, 2024

@edwardfhsiao

I've put up a pull request to add @RokasAniss! 🎉

from react-inputs-validation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.