Comments (4)
+1
from yandex-map-react.
It would be smarter to use CONSTANTS like
const MARKER_LAYOUT = "MarkerLayout";
switch() {
case MARKER_LAYOUT:
...
}
from yandex-map-react.
@dropfen constants with strings still will not help when file is minified because component displayName
is not provided for MarkerLayout
and BallonLayout
. So there are two options (maybe more, I can come up with only two now):
- provide
displayName
forMarkerLayout
andBallonLayout
components - compare
component.type
, notcomponent.type.name
(this is what I am proposing in #21)
from yandex-map-react.
my point is to use constants instead of all strings ( e.g dislayName: MARKER_LAYOUT
etc. )
Am 13.09.16 um 15:54 schrieb Sergey:
@dropfen https://github.com/dropfen constants with strings still
will not help when file is minified because component |displayName| is
not provided for |MarkerLayout| and |BallonLayout|. So there are two
options (maybe more, I can come up with only two now):
- provide |displayName| for |MarkerLayout| and |BallonLayout| components
- compare |component.type|, not |component.type.name| (this is what
I am proposing in #21
#21)—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACKYhzluog7uMQIiNGD51CuapNWL9Tlyks5qpqsogaJpZM4JZ1wQ.
from yandex-map-react.
Related Issues (20)
- Lon/lat stuff
- Support for Polyline, Polygon, Rectangle
- Module not found: Error: Cannot resolve module 'yandex-map-react' HOT 3
- proposal: add options and properties props handling to MapMarker component HOT 2
- Cannot update center through props HOT 2
- onPress
- server-side rendering HOT 3
- Доступ к ymaps.geocode() или прямой доступ к API HOT 3
- How to use BalloonLayout? HOT 1
- Load API params
- add ./lib to .gitignore
- Set lang parameter HOT 3
- 'bounds' not work HOT 3
- Problem with STYLE props
- Question: How to translate coordinates to address?
- method for update points on the map
- Missing onMapAvailable in component propTypes
- Language support HOT 1
- Adding a control element RouteButton
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yandex-map-react.