C++17 string_view about simple-web-server HOT 8 OPEN

Lol, sure, I'll do it for the fame and fortune!

from simple-web-server.

Brilliant! Would you mind creating a pull request so that you get credited for this:)?

from simple-web-server.

@eidheim Can't seem to push my PR. Getting permission denied.

from simple-web-server.

@SethHamilton You need to fork this repository on your account, then you push your changes there. Then you can create a Pull Request to eidheim's repo.

from simple-web-server.

I've made the PR here: #214

This is failing CI, but I think it's because it's not set to the C++17 standard for compilation.

from simple-web-server.

@pboettch @eidheim Ok, so, there is a (stupid) flaw with __has_include, it checks for the presence of the include, not whether it will compile or not. When not compiling with C++17 flags it will still pass. I'm now thinking a simple USE_CPP17_STRING_VIEW define might be the best way of selecting this.

The alternative would be to use the __cplusplus flag and check for C++17, but compilers like MSVC are refusing to switch this flag to the standard date for C++17 until they are fully compliant (gcc and clang don't seem to make this distinction). So, the option there would be to test for the right __cplusplus version if it's not MSVC and perhaps another test for a specific MSVC define (if I can find one).

from simple-web-server.

like perhaps something like this:

#if defined(__has_include) && __has_include(<string_view>) && (__cplusplus >> 201402L || (defined(_MSC_VER) && _MSC_VER >= 1912))
#include <string_view>
namespace SimpleWeb { using string_view = std::string_view; }
#elif !defined(USE_STANDALONE_ASIO)
#include <boost/utility/string_ref.hpp>
namespace SimpleWeb { using string_view = boost::string_ref; }  
#else
namespace SimpleWeb { using string_view = const std::string &; }
#endif

I'm starting to lean toward something like USE_CPP17_STRING_VIEW, but I also see that potentially limiting going forward, C++17 features like string_view are going to be normal eventually.

from simple-web-server.

This is compiling. I've added two tests with the s-std=c++17 compiler flag with and without USE_STANDALONE_ASIO
#214

from simple-web-server.