Comments (7)
@eikek WDYT?
from calev.
Hi @pawelkaczor ,
While it is a nice idea, I don't think it fits into the scope of this lib :S. See I don't want to add more features; it's only parsing + generate the next time based on the calendar event expression. You could explore the calendar topic by its own library maybe (the core module has no other dependencies so it's quite lightweight to depend on it)? I can imagine many more things to come, like attendees, locations, ical etc. - and this is not the right place. Also it could work with cron expressions, too maybe (there is cron4s).
from calev.
In general, I understand your point. I agree that the scope of the lib should be limited.
That's why I treat the Calendar API only as a generalization of CalEvent API that 1) can deal with sets of CalEvents 2) could benefit from optimizations. Calendar containing single CalEvent instance is equivalent of single CalEvent instance (and it is nothing more).
The CalEvent API could be replaced with Calendar API (but also both apis could be present).
Proposed Calendar domain has nothing to do with general/abstract Calendar domain. Notice that DailyCalendar, WeeklyCalendar concepts are nothing more than categorization of CalEvent sets requiring no additional information.
from calev.
Also it could work with cron expressions, too maybe (there is cron4s).
Yes, you are right that Calendar could work also with cron based calendar events, so this is valid argument against adding Calendar to this project. But there also counter-arguments. calev-akka could support Calendars.
from calev.
The CalEvent API could be replaced with Calendar API (but also both apis could be present).
I disagree. The CalEvent is really only the representation of the "*-*-* 12:00"
kind of string, and it is natural to me to obtain the next matching date given a reference date from it, because this is the only reason it exists. The Calendar now involves names (Strings) and a map and a ScheduledEvent. I don't need all of this. This is more than what is here now; it's building on top of what this lib provides. I really think this should be its own project.
calev-akka could support Calendars.
To me this is again a reason for a separate project :-) Other submodules can't easily support it, so I think it's better in a separate project which can be more specialized for akka. However, it would be ok to me to add it to the akka submodule only.
from calev.
OK. No problem. If I need this new Calendar stuff on my current project I will implement it somewhere else (not sure whether calev-akka is good place but thank you for the suggestion).
from calev.
Thank you!
from calev.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from calev.