Comments (7)
Great thanks all.
I have added a deprecation notice and will remove this section of the README in due time.
Closing this issue now, please feel free to open if needed :-)
from react-masonry-component.
Maybe this was necessary with older versions of masonry and imagesloaded ??
from react-masonry-component.
Hi @hburrows
Which version of Webpack are you using?
At the time of writing the Readme, the import order Webpack used was AMD then commonjs. This meant that some dependencies didn't play nice (imagesloaded plus others)
Things may have changed though, so thanks for bringing this up :-)
from react-masonry-component.
@afram Thanks for the followup. I'm currently using Webpack version 1.13.2 (which is the most recent in the 1.X line).
from react-masonry-component.
Hmm, I wouldn't have thought they would not change such a critical implementation detail without a major version bump, so I'd be very surprised if the import order has changed in that version. I'll check my setup when I have a second and report back.
from react-masonry-component.
I also installed the npm package without any changes to my webpack configuration (I don't use the import-loader).
It works for me, I cannot find any noticeable problems.
I did look into all the top level packages used by this component and all seem to support webpack officially. Probably that is what changed.
The only thing which could still behave weird is this package's conditional "require" statements which depend on the "isBrowser" boolean. I am not sure how webpack will handle that but I assume it would still require them which would mean they are eventually bundled in all the builds (server side and client side if you do both).
I am using that in SSR scenario and all seems to work as said before.
webpack: 1.13.3
-- [email protected]
+-- [email protected]
| `-- [email protected]
+-- [email protected]
| `-- [email protected]
+-- [email protected]
+-- [email protected]
+-- [email protected]
`-- [email protected]
+-- [email protected]
`-- [email protected]
`-- [email protected]
`-- [email protected]
from react-masonry-component.
imports-loader
for masonry-layout 4.x.
Hunting down the original issue and trying to find a reason for why things work now, I stumbled across this comment by the Masonry author:
Masonry v4.0 and fizzy-ui-utils v2.0.1 has a fix for this issue, using the same package names for AMD and CommonJS dependencies.
from react-masonry-component.
Related Issues (20)
- Is there a way to add a class to the items at the bottom of the grid? HOT 2
- Masonry slide effect does not work HOT 2
- Small Bug HOT 2
- Is there any way to animate fading out elements on update?
- RTL Support HOT 1
- Demo website is broken HOT 2
- How to centre the images? HOT 1
- onImagesLoaded is being called twice HOT 1
- Is it possible to show different widths? HOT 1
- A simple CodeSandbox image gallery example
- Update to React 17 HOT 4
- What are the masonry options properties? HOT 2
- Need Help: Not able to add gutter between the cards.
- Demo not working? HOT 3
- Masonery not correctly layout because force to have invisible columns
- how to fix 'Image elements do not have explicit width and height' in pageSpeed
- Support React 18 HOT 2
- Add support for Scss/css module .
- it works only very first time and then it loses position HOT 1
- I seem to have no control over the height of the masonry component HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-masonry-component.