IE not support fill() method. about react-star-ratings HOT 8 CLOSED

Yeah, looks like that is also not supported.

Let me add the polyfill:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

from react-star-ratings.

Wow.. Sorry, my fault.. Looks like all good now.. Thanks for fast replies. :)

from react-star-ratings.

Oh shoot. I thought babel would have compiled that to a format that supports ie. I can make a change so that I don't use fill though, so no worries.

You can also checkout this repo I made recently as I am pretty sure I don't use fill:

https://github.com/ekeric13/react-ratings-declarative

from react-star-ratings.

Cool, I'll take a look. :) 👍

from react-star-ratings.

@luizrrodrigues Think I got it working without .fill for this repo as well now. but for version 2.x. I will need to look into how to release multiple different versions of an npm package before updating the v1 api.

edit: let me know if you experience any issues. I would have to download a vm to test myself on ie. Just did a quick fix that should support ie.

from react-star-ratings.

Just update to latest version, have error with other method isInteger.

from react-star-ratings.

humm. Looks like not working well, stars now ignoring 'starWidthAndHeight'

from react-star-ratings.

You might need to change the props if you are using the new api.

https://github.com/ekeric13/react-star-ratings#api-v2

from react-star-ratings.