Need Routing Info about bacnet HOT 5 CLOSED

Hi @LADSoft thank you for sharing. May I ask if you have already implemented this in your own fork? If yes, maybe you would be willing to open a pull request to have it merged here? I sounds like a valid use case. I'm just worried if I will be able to test it correctly and it seems that you already have a setup for this. If you didn't implement this yet or you are using a different library that covers this use case, then would you mind testing the PR before it's merged?

from bacnet.

Thanks, I checked and got the ok from my supervisor to do a PR for this project. We are porting both a client and server from the C language BACnet stack by Karg to C# so I can test the server-side changes against the old version of our client... both had previously been to plugfest a couple of times so we are pretty confident in how they work. Give me a couple of weeks to finish up the testing then I will push something. I may try to add something else we need. if that is ok... response processing for GetEventInformation...

from bacnet.

Thank you @LADSoft this sounds great 🙂 This library is far from perfect, but since I managed to extract it from YABE and it allowed me to implement the integration I needed, we decided to host it for others to use too and not have to repeat the unnecessary work we had to do. Since then every now and then someone adds or fixes this and that, so feel free to open PR for anything you find missing or not working.

from bacnet.

thank you @gralin for your effort in this, it does help not to have to host our own version. I noticed you optimized a little too 😄.

I ended up adding everything on our wishlist for the server side now... that includes the change I talked about earlier as well as support for sending confirmed notifications, and server side support for event acknowledge and get event information. oh and I added a simple dispatcher for network messages that we need to support 'WHO_IS_ROUTER_TO_NETWORK/I_AM_ROUTER_TO_NETWORK'... all it does is route network layer messages into C# events the same way the confirmed and unconfirmed messages are done.

I just have to test and make sure nothing is broken. Probably within the next couple of weeks as I have to work on other projects for a while.

I was wondering, I don't think my version of the lib will be binary compatible with the old one... the binary version of the api is likely to be modified by my changes because I did things like add a missing field to a structure, and add defaulted arguments to lots of functions. But I do intend it to be backward compatible at the source code level. Is that ok?

from bacnet.

added to the list: a couple of minor bug fixes probably noone ran into before... also sending of 'abort' and 'reject' error messages is being overhauled to work as per the spec. Meanwhile I really want to change one of the reject reasons from 'RECOGNIZED_SERVICE' to 'UNRECOGNIZED SERVICE' but that would mean source-level incompatibility. Sigh.

from bacnet.