Comments (7)
#3885 opened for this.
from apm-agent-nodejs.
Nope. I didn't add perms to the needed job in the labeler workflow.
from apm-agent-nodejs.
That didn't work. Or at least likely didn't work. I just got another failure:
https://github.com/elastic/apm-agent-nodejs/actions/runs/8191312536
Invalid workflow file: .github/workflows/labeler.yml#L23
The workflow is not valid. .github/workflows/labeler.yml (Line: 23, Col: 7): Unexpected value 'permissions' .github/workflows/labeler.yml (Line: 48, Col: 7): Unexpected value 'permissions'
from apm-agent-nodejs.
The labeler workflow is always failing now: https://github.com/elastic/apm-agent-nodejs/actions/workflows/labeler.yml
from apm-agent-nodejs.
Nope. That didn't work.
https://github.com/elastic/apm-agent-nodejs/actions/runs/8210315149/job/22457519729
Adding labels agent-nodejs to issue #3905
/home/runner/work/_actions/AlexanderWert/issue-labeler/v2.3/node_modules/@octokit/request/dist-node/index.js:66
const error = new requestError.RequestError(message, status, {
^
RequestError [HttpError]: Resource not accessible by integration
at /home/runner/work/_actions/AlexanderWert/issue-labeler/v2.3/node_modules/@octokit/request/dist-node/index.js:66:23
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
status: 403,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-encoding': 'gzip',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Fri, 08 Mar 2024 23:39:55 GMT',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'GitHub.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
'transfer-encoding': 'chunked',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'issues=write; pull_requests=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': '38CC:065E:E5C293:1B7E910:65EBA1CB',
'x-ratelimit-limit': '15000',
'x-ratelimit-remaining': '14998',
'x-ratelimit-reset': '1709944795',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '2',
'x-xss-protection': '0'
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/elastic/apm-agent-nodejs/issues/3905/labels',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'octokit.js/16.43.2 Node.js/16.20.2 (Linux 6.5; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: '{"labels":["agent-nodejs"]}',
request: {
hook: [Function: bound bound register],
validate: {
issue_number: { required: true, type: 'integer' },
labels: { required: true, type: 'string[]' },
number: { alias: 'issue_number', deprecated: true, type: 'integer' },
owner: { required: true, type: 'string' },
repo: { required: true, type: 'string' }
}
}
},
documentation_url: 'https://docs.github.com/rest/issues/labels#add-labels-to-an-issue'
}
Lovely. That documentation_url
says:
The token must have at least one of the following permission sets:
issues:write
pull_requests:write
and I added the former for those two:
apm-agent-nodejs/.github/workflows/labeler.yml
Lines 10 to 14 in 7a697bc
based on what I saw in the .NET agent here:
https://github.com/elastic/apm-agent-dotnet/blob/2805f3ada1940d48ad0b2f90753de19e2995743a/.github/workflows/labeler.yml#L8-L10
I assume my comment isn't impactful.
This one is getting frustrating.
from apm-agent-nodejs.
This one is getting frustrating.
And it continues...
The labeler workflow is now failing with:
Run actions-ecosystem/action-add-labels@v1
Error: HttpError: Resource not accessible by integration
Error: Resource not accessible by integration
e.g.: https://github.com/elastic/apm-agent-nodejs/actions/runs/8325325014
next
Next attempt will be to switch to the technique(s) being used in apm-agent-java which Riccardo (internal Slack comment: https://elastic.slack.com/archives/C9A6ANR5Y/p1710418037227959) confirmed is "the way" now.
from apm-agent-nodejs.
5th time's the charm.
from apm-agent-nodejs.
Related Issues (20)
- Support mtls connection
- test issue to see if labeler action works on an issue HOT 1
- edge "test-nightly" failing after kafka/zookeeper addition
- TAV failing for `[email protected]` HOT 4
- Agent doesn't capture uncaught exceptions or unhandled rejections HOT 11
- Request body is logged even with `captureBody: off` HOT 17
- undici instrumentation can add duplicate trace-context headers, which can break Elasticsearch HOT 2
- release fails in make-distribution.sh step
- KafkaJS instrumentation throw exception on "tombstone message" HOT 2
- Agent not working with Yarn Pnp + NextJS HOT 5
- including parsed "cookie" HTTP request header in ingest can lead to mapping conflicts HOT 2
- Elastic APM Agent Node arbitrary code Injection due to improper sanitization of the timezone parameter HOT 2
- APM Server transport error (ERR_SOCKET_TIMEOUT): Socket timeout HOT 5
- Lambda "nodejs20.x" is out, our published Lambda layers should say they support it HOT 2
- bitrot updates HOT 1
- [Question] Support bullmq HOT 7
- make docker image(s) multi-platform and include linux/arm64 HOT 4
- opentelemetry-bridge should use the ELASTIC_APM_API_KEY HOT 1
- Any plans to support hyper-express please? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apm-agent-nodejs.