Comments (7)
danajuratoni
commented on August 20, 2024
1
@parth-crest please update this ticket as soon as the changes as merged via the PR you mention, as that PR is not linked to this ticket.
from connectors.
parth-crest
commented on August 20, 2024
@danajuratoni previously we were getting empty list ([]) if user has not passed any value in the "List of MySQL databases" from the UI. Now we are getting empty string ("") which breaks our code. We have refactored our code to work in both cases empty list and empty string and it will fetch all the databases in both the cases.
from connectors.
parth-crest
commented on August 20, 2024
Should we change our code to index nothing if user has passed empty value in "List of MySQL databases"?
from connectors.
danajuratoni
commented on August 20, 2024
Yes, please adjust the code such that no databases are ingested if the list is empty.
from connectors.
parth-crest
commented on August 20, 2024
Sure, we will update that.
from connectors.
parth-crest
commented on August 20, 2024
@danajuratoni Code is merged to main. We can close this issue.
cc @tarekziade
from connectors.
danajuratoni
commented on August 20, 2024
@danajuratoni Code is merged to main. We can close this issue.
cc @tarekziade
Closing per comment above
from connectors.
Related Issues (20)
- Make connectors work with python 3.10, 3.11 and 3.12
- Incremental Sync should consider updates that doesn't change timestamp
- Connectors services don't shut down immediately if new task added to pool
- Postgres connector: temporary file size exceeds temp_file_limit HOT 5
- In the github connector, for Access Control Sync, allow_access_control field is missing for the document indexed. HOT 4
- Retirement of Office 365 connectors within Microsoft Teams HOT 1
- Postgres advanced sync rules missing in Native Connectors HOT 2
- [MSSQL] Impossible to sync tables that have columns of MSSQL-specific types or even standard datetime
- '_asyncio.Task' object has no attribute 'name' HOT 2
- [MySQL] Connector dies if connection to MySQL times out due to slow ingestion
- Throttle based on cluster capacity HOT 2
- [Dropbox] `file_path` property does not take directory hierarchy into account
- [Confluence] body content for some records includes HTML tags
- Add more INFO logs and metrics when running connectors with data extraction service
- Connector scheduling doesn't handle restarts after scheduled sync time
- MS SQL Connector: Client does not have encryption enabled but it is required by server HOT 6
- Dependency Dashboard
- Elasticsearch OneDrive native connector is missing to index the field mime-type. HOT 2
- Network Drive connector DLS mapping CSV gives error - IndexError: list index out of range HOT 4
- [ServiceNow] Connector to support custom tables HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connectors.