Comments (6)
Pinging @elastic/kibana-gis (Team:Geo)
from ems-file-service.
thanks @Chaferfu for pointing this!! indeed the area is missing because it's out of the department of Rhône. On the wikipedia page it has listed with the INSEE code 69M
but that code is not showing in the official ISO listing, or the wikidata identifiers section. Still, there's a correct relationship with OSM data.
- Wikipedia: https://en.wikipedia.org/wiki/Lyon_Metropolis
- Wikidata: https://www.wikidata.org/wiki/Q16665897
- OSM relation: https://www.openstreetmap.org/relation/4850450#map=11/45.7486/4.8766
we'll take a look, thanks again for reporting!
from ems-file-service.
@nickpeihl should we add Q16665897 to the France Wikidata entry? Similarly, add to the region entry the identifiers? Both pages are protected so I can't edit them 😓
Another temporal solution (but I don't like it much) is to attach the geometry in the SPARQL query. Something like this.
...
} UNION {
VALUES ?id { wd:Q16665897 }
VALUES ?iso_3166_2 { "FR-69M" }
VALUES ?insee { "69M" }
OPTIONAL { ?id rdfs:label ?label_en . FILTER(LANG(?label_en) = "en") }
}
...
Let me know what you think.
from ems-file-service.
@jsanz I did a little more research into this and the best authoritative source I can find is here showing the Metropolis of Lyon within the Rhone department boundary. So I believe our map is incorrect.
The Auvergne-Rhône-Alpes region properties for Contains administrative division
include Rhone and Metropolis of Lyon as separate entities which have boundaries that do not overlap.
There is another Wikidata item called departmental district of Rhone which appears to be the successor of Rhone. Rather than make a potentially controversial (and possibly inaccurate) change in Wikidata, I propose we modify the SPARQL query to swap the Wikidata IDs similar to how we do this with Taiwan in China provinces.
This is the query modified with my suggestion.
from ems-file-service.
Thanks for taking a look @nickpeihl, I've also checked
- Open Data from Eurogeographics
- GADM data for France
And in both sources, Lyon is part of the greater department so I will implement your suggested fix next week.
from ems-file-service.
@Chaferfu this issue was addressed at #137, we plan to release to production all changes in feature-layers
over the following weeks, thanks for reporting this!
from ems-file-service.
Related Issues (20)
- [Meta] EMS 7.14 HOT 4
- [Meta] EMS v7.15 HOT 1
- Add administrative region layers for countries in the Arabian Peninsula HOT 2
- hello HOT 1
- [Meta] EMS 7.16 HOT 1
- [Meta] EMS 8.0 HOT 1
- France Departments winding order incompatible with Vega HOT 5
- Meta: rename master to main
- Upgrade to Node 16
- Upgrade all GeoJSON layers to follow RFC7946
- Remove region identifiers with values that are too common HOT 1
- Telangana and Andhra Pradesh regions names in India are incorrect
- Fix region name for GB-LND in administrative regions layer
- New Zealand EMS administrative map seems to be missing. Can this please be added? HOT 1
- "<svg onload=alert(1337)>%00"><img src=x onerror=alert`1`//"
- Fix Morocco regions label
- Upgrade to NodeJS 18
- [EMS] Include commit identifier in release artifacts
- Generate EMS File Service manifests for serverless
- [EMS] Create a minimal document for root directory
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ems-file-service.