Giter VIP home page Giter VIP logo

Comments (6)

elasticmachine avatar elasticmachine commented on July 18, 2024

Pinging @elastic/kibana-gis (Team:Geo)

from ems-file-service.

jsanz avatar jsanz commented on July 18, 2024

thanks @Chaferfu for pointing this!! indeed the area is missing because it's out of the department of Rhône. On the wikipedia page it has listed with the INSEE code 69M but that code is not showing in the official ISO listing, or the wikidata identifiers section. Still, there's a correct relationship with OSM data.

we'll take a look, thanks again for reporting!

from ems-file-service.

jsanz avatar jsanz commented on July 18, 2024

@nickpeihl should we add Q16665897 to the France Wikidata entry? Similarly, add to the region entry the identifiers? Both pages are protected so I can't edit them 😓

Another temporal solution (but I don't like it much) is to attach the geometry in the SPARQL query. Something like this.

...
} UNION {
  VALUES ?id { wd:Q16665897 }
  VALUES ?iso_3166_2 { "FR-69M" }
  VALUES ?insee { "69M" }
  OPTIONAL { ?id rdfs:label ?label_en . FILTER(LANG(?label_en) = "en") }
}
...

Let me know what you think.

from ems-file-service.

nickpeihl avatar nickpeihl commented on July 18, 2024

@jsanz I did a little more research into this and the best authoritative source I can find is here showing the Metropolis of Lyon within the Rhone department boundary. So I believe our map is incorrect.

The Auvergne-Rhône-Alpes region properties for Contains administrative division include Rhone and Metropolis of Lyon as separate entities which have boundaries that do not overlap.

There is another Wikidata item called departmental district of Rhone which appears to be the successor of Rhone. Rather than make a potentially controversial (and possibly inaccurate) change in Wikidata, I propose we modify the SPARQL query to swap the Wikidata IDs similar to how we do this with Taiwan in China provinces.

This is the query modified with my suggestion.

from ems-file-service.

jsanz avatar jsanz commented on July 18, 2024

Thanks for taking a look @nickpeihl, I've also checked

And in both sources, Lyon is part of the greater department so I will implement your suggested fix next week.

from ems-file-service.

jsanz avatar jsanz commented on July 18, 2024

@Chaferfu this issue was addressed at #137, we plan to release to production all changes in feature-layers over the following weeks, thanks for reporting this!

from ems-file-service.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.