Comments (5)
stephenhensley
commented on May 31, 2024
Agreed tone definitely seems awkward in context. There is a trivial onepole in dsp.h already, but I think a more specific appropriate name would be fitting (i.e. OnePoleIir, or similar)
from daisysp.
stephenhensley
commented on May 31, 2024
Also worth mentioning, good catch on the unused vars! I just noticed them (along with a few others) myself while testing something on my end. They're fixed on #5, though I'll probably move the minor maintenance stuff I caught to a separate PR to merge sooner.
from daisysp.
upbeat27
commented on May 31, 2024
I'd leave iir out of the name since it is implied.
The one pole in dsp.h looks like it has a bug with 'out' not being dereferenced. That one has a bit awkward naming, with the preceding f (for float?) It could be a macro instead and work for floats or doubles (this is coming from a c guy).
For example: https://github.com/pichenettes/stmlib/blob/master/dsp/dsp.h
from daisysp.
stephenhensley
commented on May 31, 2024
After some deliberation, the name 'Tone' is going to stay. This is what it's called in Csound/soundpipe where this was ported from (albeit a simple filter, the credit should stay).
from daisysp.
csounder
commented on May 31, 2024
excellent decision.
- for sure there are some confusing and counterintuitive names in the
collection of almost 2000 Csound opcodes; but they also have historical
significance and are a standard. There was a day when we "all" wished that
tone or atone had more poles and so, we added other filters to Csound that
did. Now, there are a lot more interesting, powerful, and amazing filters
in soundpipe (from Csound) and in Csound and in the Csound sources that
Daisy can draw upon, port and feature. And I am sure that you will. And
when all you need is a little, fast, tone filter for a little damping of
your reverb algorithm, you will only have to use tone and nothing more
computationally intensive.
…_____________________________________________
*Dr. Richard Boulanger*
Professor of Electronic Production and Design
Professional Writing and Music Technology Division
Berklee College of Music
facebook: https://www.facebook.com/richard.boulanger.58
On Mon, May 18, 2020 at 10:03 PM Stephen Hensley ***@***.***> wrote:
After some deliberation, the name 'Tone' is going to stay. This is what
it's called in Csound/soundpipe where this was ported from (albeit a simple
filter, the credit should stay).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALWYFXYQXQUZMJM7N3NC6LRSHSHTANCNFSM4LDMIT7A>
.
from daisysp.
Related Issues (20)
- Overriding dsp.h HOT 5
- String.h breaking compilation after directory refactoring HOT 4
- Emscripten support HOT 1
- Problems with the SVF Filter at high cutoff frequencies HOT 7
- Building on a Raspberry Pi ? HOT 4
- Shaper oscillators emit DC HOT 2
- Style guide suggests slow code passing by const & HOT 1
- ADSR produces small step and audible click in decay or release phase HOT 4
- C++ 11 compatibility HOT 9
- Add platform dependent assert macro HOT 3
- Pitch shifter accepts transpose < 0.0f but does not work HOT 1
- documentation build action is failing HOT 1
- std::sin usage in Looper HOT 3
- Svf filter does not like to be modulated HOT 3
- CMake errors HOT 4
- moogladder tanh incorrect HOT 2
- ReverbSC does not initialize at 96kHz HOT 2
- SetFreq on VariableShapeOscillator seems to not work HOT 2
- Envelope timings incorrect HOT 1
- typo in fastroot() ? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from daisysp.