Giter VIP home page Giter VIP logo

Comments (8)

MarshallOfSound avatar MarshallOfSound commented on August 29, 2024

That worked for a time, but it seems to have stopped working again and I don't have much visibility into the cause. Two weeks ago I landed a PR electron/hubdown#20 to address a bug in the current version of hubdown.

I thought I explained how the system worked at the time, but when a PR is merged someone needs to be around to enter a 2 factor code for the publish and in this case you merged it late at night and no one was around. I only saw the notification the next day iirc. The system works, just in this case you need to make sure that someone is actually around with a 2FA token.

I'm not strongly opinionated either way on this but I would highlight that if part of the reason for this request is to make it "easier" by removing the 2FA step for publishing I'm slightly against it. I strongly believe that all npm packages should have 2FA for publishing and just because it adds a small level of inconvenience we shouldn't throw that additional safety away.

from governance.

felixrieseberg avatar felixrieseberg commented on August 29, 2024

This sounds like you’re offering more help and official support from
GitHub, which seems like a 🎁 to me.

I’m pro!

from governance.

zeke avatar zeke commented on August 29, 2024

@MarshallOfSound thanks for chiming in. I should clarify that I am pro-2FA and that you did indeed explain how the system works, but my issue is that as an outside contributor I don't have visibility into whether a release failed because of a technical issue, or because nobody was around to respond to the 2FA ping in Slack.

What would be the best way to ensure that someone is around to press the button for future releases?

I've opened a followup PR that can be merged when folks are around and ready to respond to the 2FA request: electron/hubdown#21

All that said, I don't feel strongly about where this module lives. I just want to be sure that GitHub's Docs team can effectively make improvements as needed.

from governance.

zeke avatar zeke commented on August 29, 2024

Friendly bump. This is still pending: electron/hubdown#21

from governance.

zeke avatar zeke commented on August 29, 2024

Hey I just realized that hubdown is actually no longer used by the Electron website, so I think it makes sense to find a new home for it. We actively use hubdown for help.github.com, and would be happy to maintain it in the @docs org.

Can y'all help make that happen?

from governance.

deermichel avatar deermichel commented on August 29, 2024

Hey there, I think hubdown is still used for the Electron docs (https://github.com/electron/i18n). Anyway, I haven't worked on this for a while and might not have a complete overview of the current project structure.

from governance.

rashd640 avatar rashd640 commented on August 29, 2024

مرحباً يا (الإلكترون/wg-الموقع الشبكي👋

أود أن أطلب أن نحرك الـ...hubdownمشروع من مشروع مشروع من(أ)من org إلى(د)org و ابدأ في نشرها إلى npm باستخدام حساب npm مملوك لـ (جيتHub).

أعمل في فريق توثيق المنتجات في جيتهوب، والحفاظ على المساعدة، github.com والمطور. github.com. نحن نستفيد منhubdownولهم مصلحة في الحفاظ عليه محدثة، وخالية من الحشرات، وأداء.

وقد بُذلت مؤخراً جهداً لتأليف عملية نشر في هذه الوحدة باستخدام التعادل المتعدد العوامل والإطلاق الدلاي (شكراً(دي رمشيل)و(مارس مارس//ف سوند)هذا عمل لفترة من الوقت، ولكن يبدو أنه توقف عن العمل مرة أخرى وليس لدي الكثير من الرؤية في القضية. قبل أسبوعين هبطت في غرفة شرطةالإلكترون/هوابوت رقم 20لمعالجة حشرة في النسخة الحالية منhubdownوقد تم استعراض هذا الاستعراض ودمجه في إطار قصير، ولكن للأسف لم يتم إطلاق إطلاق جديد.

هل ستكون منفتحة على الهجرة هذه الوحدة إلى منزل جديد حيث ستحصل على المزيد من الاهتمام المنتظم؟ نعد بأن نتبع (سيمفر) وأن نبقي شعب (إلكتون) في الحلقة مع تحديث المشروع✋

(ج ج ج)(سارات) (ج) جوليانغروبر دونة

from governance.

zeke avatar zeke commented on August 29, 2024

I'm no longer on GitHub's docs team, and it looks like they've since stopped using hubdown and instead rolled their own internal remark processor.

Closing!

from governance.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.