Possibility to define when to throw exceptions about cosmonaut HOT 5 CLOSED

Aha, I am not setting this parameter explicitly, I assume the default is retry infinitely? I’m happy if it’s going to retry on it’s own, saves me some plumbing work. Just dug into your code to find this parameter and indeed, it’s defaulted to retry indefinitely. I’ll play around with this to see if I can trigger our own retry policy, as we are trying to capture some metrics/logs during such retry as well. Thanks! Van: Nick Chapsas <[email protected]> Verzonden: woensdag 3 april 2019 14:16 Aan: Elfocrash/Cosmonaut <[email protected]> CC: Yoni Nijs <[email protected]>; Author <[email protected]> Onderwerp: Re: [Elfocrash/Cosmonaut] Possibility to define when to throw exceptions (#79) First and foremost thanks for your kind comments. Something that Cosmonaut definitely won't do is throw any exception other than the TooManyRequests one. The main reason why is because I removed it first in Cosmonaut and the the Cosmos DB team also removed it on the v3 SDK so I can't add something back that I will have to remove when I move this project to the v3 SDK anyway. Now, about the TooManyRequests thing, as far as I remember Cosmonaut will actually throw this exception if you turn Infinite retrying off. Did you try doing that? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#79 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ArmKUeHnZ180PyvNBcLqPV1BBW4lvmsoks5vdJtsgaJpZM4caSSj>.

Agree! That does explain why a little performance test didn’t break anything, while I was expecting things to fall over when the db was under heavy load (as I was investigating how to prevent this, but it looks like I was trying to prevent something which didn’t need preventing as it was already taken care of😊). Van: Nick Chapsas <[email protected]> Verzonden: woensdag 3 april 2019 14:25 Aan: Elfocrash/Cosmonaut <[email protected]> CC: Yoni Nijs <[email protected]>; Author <[email protected]> Onderwerp: Re: [Elfocrash/Cosmonaut] Possibility to define when to throw exceptions (#79) Retries should be logged as well. They just retry silently. I set the default behavior to be infinite retry for 429s cause I can't see the scenario where you wouldn't wanna retry due to a transient error. I've never been like : * Server: Oi I can't handle that I'm under heavy load, try in 100ms * Client: Ok, I won't retry that — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#79 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ArmKUS3xvzHiyQTGNUeh_0WpSt5ZvZf4ks5vdJ2VgaJpZM4caSSj>.