Discovered MQTT entities with a name that is equal to the device name about xiaomi-dafang-hacks HOT 12 CLOSED

@jonwaland - I had the same issue yesterday trying to figure this out. The commit "null" is the clue something is wrong.

I ssh into each of my cameras and had:

cd /system/sdcard/

cat VERSION
{"date":"null","repo":"/","branch":"master","commit":"null"}

Same null message you had. Not sure when this stopped working. I created a GitHub token (classic type) for the cams to use for updates as the default (anonymous maybe?) seems to be rate limited and was silently failing.

Ran the update script with my github ID & token I created for the cams to use:

./autoupdate.sh -u reefland:<git_hub_token>

And I saw the 1st line, it was updating to the latest commit:

epo has changed. Upgrade to last commit cd80244
autoupdate.sh is up to date.
run.sh is up to date.
uEnv.bootfromnand.t20l.txt is up to date.
uEnv.bootfromnand.txt is up to date.
uEnv.bootfromsdcard.t20l.txt is up to date.
uEnv.bootfromsdcard.txt is up to date.
bin/README.md is up to date.

...

stopping /system/sdcard/controlscripts/telegram-bot
stopping /system/sdcard/controlscripts/telnet_server
stopping /system/sdcard/controlscripts/timelapse
--------------- Updating files ----------
---------------    Reboot    ------------
A reboot is needed, do you want to reboot now?
[Y]es or [N]o
Y

After rebooting the camera:

cd /system/sdcard/

cat VERSION
{"date":"2023-11-05T12:03:16Z","repo":"EliasKotlyar/Xiaomi-Dafang-Hacks","branch":"master","commit":"cd80244"}

You can see the config/entity name changes reflected in MQTT Explorer within seconds if you have that. After upgrading each camera, bounced HA and warning message was gone.

from xiaomi-dafang-hacks.

Should be fixed on beta branch

from xiaomi-dafang-hacks.

upgraded and rebooted cameras - restarted HA - no error - thanks @reefland !

from xiaomi-dafang-hacks.

+1

from xiaomi-dafang-hacks.

Yes it seems like there will need to be some changes made to the mqtt discovery naming convention to align with HAs naming.

from xiaomi-dafang-hacks.

This PR should fix the issue: #1871

Please test it and let me know if the issue is fixed. Thanks!

from xiaomi-dafang-hacks.

Right, this will impact everyone with HA and MQTT enabled

from xiaomi-dafang-hacks.

other than installing the beta, what is required to clean it all up?

from xiaomi-dafang-hacks.

restart camera, restart HA

from xiaomi-dafang-hacks.

have power cycled cameras, and restarted HA. no change:

2023-10-31 15:12:21.811 WARNING (MainThread) [homeassistant.components.mqtt.mixins] MQTT entity name starts with the device name in your config {'name': 'dafang2 Motion Sensor', 'unique_id': '7811dc7a24d3-motion-sensor', 'device': {'identifiers': ['7811dc7a24d3'], 'connections': [['mac', '78:11:dc:7a:24:d3']], 'manufacturer': 'Xiaomi', 'model': 'Dafang', 'name': 'dafang2', 'sw_version': 'null - beta - null'}, 'state_topic': 'myhome/dafang2/motion', 'device_class': <BinarySensorDeviceClass.MOTION: 'motion'>, 'payload_on': 'ON', 'payload_off': 'OFF', 'payload_not_available': 'offline', 'qos': 0, 'force_update': False, 'encoding': 'utf-8', 'payload_available': 'online', 'availability_mode': 'latest', 'enabled_by_default': True}, this is not expected. Please correct your configuration. The device name prefix will be stripped off the entity name and becomes 'Motion Sensor'

Local Time: | Mon Nov 6 17:25:39 EST 2023
System Uptime: | 7d, 2h, 05m
Load Average: | 3.08, 2.46, 2.39

from xiaomi-dafang-hacks.

Likely the update tool failed somehow and you dont have the latest version.
Beta and Master are on the same level now.
Try with a fresh folder checkout from git. You can keep your config folder because nothing changed there for a while I think.

from xiaomi-dafang-hacks.

I think this error can be closed now

from xiaomi-dafang-hacks.